tape_previously_mounted = (dev->state & ST_READ) || (dev->state & ST_APPEND);
if (dev->state & ST_READ || dev->num_writers > 0) {
- Jmsg1(jcr, M_FATAL, 0, _("Device %s is busy. Job cancelled.\n"), dev_name(dev));
+ Jmsg1(jcr, M_FATAL, 0, _("Device %s is busy. Job canceled.\n"), dev_name(dev));
goto get_out;
}
/* Find next Volume, if any */
vol = jcr->VolList;
if (!vol) {
- Jmsg(jcr, M_FATAL, 0, _("No volumes specified. Job cancelled.\n"));
+ Jmsg(jcr, M_FATAL, 0, _("No volumes specified. Job canceled.\n"));
goto get_out;
}
jcr->CurVolume++;
}
pm_strcpy(&jcr->VolumeName, vol->VolumeName);
- for (;;) {
- if (job_cancelled(jcr)) {
- Mmsg0(&dev->errmsg, _("Job cancelled.\n"));
+ for (int i=0; i<5; i++) {
+ if (job_canceled(jcr)) {
+ Mmsg0(&dev->errmsg, _("Job canceled.\n"));
goto get_out; /* error return */
}
/*
Dmsg0(200, "calling read-vol-label\n");
switch (read_dev_volume_label(jcr, dev, block)) {
case VOL_OK:
+ stat = 1;
break; /* got it */
case VOL_IO_ERROR:
/*
}
break;
}
+ if (stat == 0) {
+ Jmsg1(jcr, M_FATAL, 0, _("Too many errors trying to mount device \"%s\".\n"),
+ dev_name(dev));
+ goto get_out;
+ }
dev->state |= ST_READ;
attach_jcr_to_device(dev, jcr); /* attach jcr to device */
- stat = 1; /* good return */
if ((dev->state & ST_TAPE) && vol->start_file > 0) {
Dmsg1(200, "====== Got start_file = %d\n", vol->start_file);
Jmsg(jcr, M_INFO, 0, _("Forward spacing to file %d.\n"), vol->start_file);
*
* Returns: NULL if failed for any reason
* dev if successful (may change if new dev opened)
+ * This routine must be single threaded because we may create
+ * multiple devices (for files), thus we have our own mutex
+ * on top of the device mutex.
*/
DEVICE * acquire_device_for_append(JCR *jcr, DEVICE *dev, DEV_BLOCK *block)
{
lock_device(dev);
block_device(dev, BST_DOING_ACQUIRE);
unlock_device(dev);
+ P(mutex); /* lock all devices */
Dmsg1(190, "acquire_append device is %s\n", dev_is_tape(dev)?"tape":"disk");
open_vols++;
}
if (dev->state & ST_FILE && dev->max_open_vols > open_vols) {
- P(mutex); /* lock all devices */
d = init_dev(NULL, (DEVRES *)dev->device); /* init new device */
d->prev = dev; /* chain in new device */
d->next = dev->next;
lock_device(dev);
block_device(dev, BST_DOING_ACQUIRE);
unlock_device(dev);
- V(mutex);
} else {
Jmsg(jcr, M_FATAL, 0, _("Device %s is busy writing on another Volume.\n"), dev_name(dev));
goto get_out;
P(dev->mutex);
unblock_device(dev);
V(dev->mutex);
+ V(mutex); /* unlock other threads */
return rtn_dev;
}