/* Responses sent to the File daemon */
static char OK_data[] = "3000 OK data\n";
+/* Forward referenced functions */
+
/*
* Append Data sent from File daemon
*
int32_t file_index, stream, last_file_index;
BSOCK *ds;
BSOCK *fd_sock = jcr->file_bsock;
- int ok = TRUE;
- DEVICE *dev = jcr->device->dev;
+ bool ok = true;
+ DEVICE *dev;
DEV_RECORD rec;
DEV_BLOCK *block;
+ DCR *dcr;
Dmsg0(10, "Start append data.\n");
- /* Tell File daemon to send data */
- bnet_fsend(fd_sock, OK_data);
-
- if (!jcr->no_attributes && jcr->spool_attributes) {
- open_spool_file(jcr, jcr->dir_bsock);
- }
-
ds = fd_sock;
- if (!bnet_set_buffer_size(ds, MAX_NETWORK_BUFFER_SIZE, BNET_SETBUF_WRITE)) {
+ if (!bnet_set_buffer_size(ds, jcr->device->max_network_buffer_size, BNET_SETBUF_WRITE)) {
set_jcr_job_status(jcr, JS_ErrorTerminated);
Jmsg(jcr, M_FATAL, 0, _("Unable to set network buffer size.\n"));
return 0;
}
- Dmsg1(20, "Begin append device=%s\n", dev_name(dev));
-
- block = new_block(dev);
- memset(&rec, 0, sizeof(rec));
-
/*
* Acquire output device for writing. Note, after acquiring a
* device, we MUST release it, which is done at the end of this
* subroutine.
*/
Dmsg0(100, "just before acquire_device\n");
- if (!(dev=acquire_device_for_append(jcr, dev, block))) {
+ if (!(dcr=acquire_device_for_append(jcr))) {
set_jcr_job_status(jcr, JS_ErrorTerminated);
- free_block(block);
return 0;
}
+ dev = dcr->dev;
+ block = dcr->block;
+ memset(&rec, 0, sizeof(rec));
+
+ Dmsg1(20, "Begin append device=%s\n", dev_name(dev));
+
+ begin_data_spool(jcr);
+ begin_attribute_spool(jcr);
+
Dmsg0(100, "Just after acquire_device_for_append\n");
/*
* Write Begin Session Record
Jmsg1(jcr, M_FATAL, 0, _("Write session label failed. ERR=%s\n"),
strerror_dev(dev));
set_jcr_job_status(jcr, JS_ErrorTerminated);
- ok = FALSE;
+ ok = false;
}
+ /* Tell File daemon to send data */
+ bnet_fsend(fd_sock, OK_data);
/*
* Get Data from File daemon, write to device. To clarify what is
* file. 1. for the Attributes, 2. for the file data if any,
* and 3. for the MD5 if any.
*/
- jcr->VolFirstIndex = 0;
+ dcr->VolFirstIndex = dcr->VolLastIndex = 0;
jcr->run_time = time(NULL); /* start counting time for rates */
for (last_file_index = 0; ok && !job_canceled(jcr); ) {
}
Jmsg1(jcr, M_FATAL, 0, _("Error reading data header from FD. ERR=%s\n"),
bnet_strerror(ds));
- ok = FALSE;
+ ok = false;
break;
}
}
if (!B_ISSPACE(*p) || !B_ISDIGIT(*(p+1))) {
Jmsg1(jcr, M_FATAL, 0, _("Malformed data header from FD: %s\n"), ds->msg);
- ok = FALSE;
+ ok = false;
break;
}
stream = (int32_t)str_to_int64(p);
if (!(file_index > 0 && (file_index == last_file_index ||
file_index == last_file_index + 1))) {
Jmsg0(jcr, M_FATAL, 0, _("File index from FD not positive or sequential\n"));
- ok = FALSE;
+ ok = false;
break;
}
if (file_index != last_file_index) {
jcr->JobFiles = file_index;
- if (jcr->VolFirstIndex == 0) {
- jcr->VolFirstIndex = file_index;
- }
- jcr->VolLastIndex = file_index;
last_file_index = file_index;
}
* The data stream is just raw bytes
*/
while ((n=bget_msg(ds)) > 0 && !job_canceled(jcr)) {
-
rec.VolSessionId = jcr->VolSessionId;
rec.VolSessionTime = jcr->VolSessionTime;
rec.FileIndex = file_index;
while (!write_record_to_block(block, &rec)) {
Dmsg2(150, "!write_record_to_block data_len=%d rem=%d\n", rec.data_len,
rec.remainder);
- if (!write_block_to_device(jcr, dev, block)) {
+ if (!write_block_to_device(jcr->dcr, block)) {
Dmsg2(90, "Got write_block_to_dev error on device %s. %s\n",
dev_name(dev), strerror_dev(dev));
- Jmsg(jcr, M_FATAL, 0, _("Cannot fixup device error. %s\n"),
+ Jmsg(jcr, M_FATAL, 0, _("Fatal device error: ERR=%s\n"),
strerror_dev(dev));
- ok = FALSE;
+ ok = false;
break;
}
}
if (stream == STREAM_UNIX_ATTRIBUTES || stream == STREAM_MD5_SIGNATURE ||
stream == STREAM_UNIX_ATTRIBUTES_EX || stream == STREAM_SHA1_SIGNATURE) {
if (!jcr->no_attributes) {
- if (jcr->spool_attributes && jcr->dir_bsock->spool_fd) {
- jcr->dir_bsock->spool = 1;
+ if (are_attributes_spooled(jcr)) {
+ jcr->dir_bsock->spool = true;
}
Dmsg0(200, "Send attributes.\n");
if (!dir_update_file_attributes(jcr, &rec)) {
+ jcr->dir_bsock->spool = false;
Jmsg(jcr, M_FATAL, 0, _("Error updating file attributes. ERR=%s\n"),
bnet_strerror(jcr->dir_bsock));
- ok = FALSE;
- jcr->dir_bsock->spool = 0;
+ ok = false;
break;
}
- jcr->dir_bsock->spool = 0;
+ jcr->dir_bsock->spool = false;
}
}
}
if (is_bnet_error(ds)) {
Jmsg1(jcr, M_FATAL, 0, _("Network error on data channel. ERR=%s\n"),
bnet_strerror(ds));
- ok = FALSE;
+ ok = false;
break;
}
}
- /*
- * We probably need a new flag that says "Do not attempt
- * to write because there is no tape".
- */
- Dmsg0(90, "Write_end_session_label()\n");
/* Create Job status for end of session label */
set_jcr_job_status(jcr, ok?JS_Terminated:JS_ErrorTerminated);
Jmsg1(jcr, M_FATAL, 0, _("Error writting end session label. ERR=%s\n"),
strerror_dev(dev));
set_jcr_job_status(jcr, JS_ErrorTerminated);
- ok = FALSE;
+ ok = false;
}
+ Dmsg0(90, "back from write_end_session_label()\n");
/* Flush out final partial block of this session */
- if (!write_block_to_device(jcr, dev, block)) {
+ if (!write_block_to_device(jcr->dcr, block)) {
Dmsg0(100, _("Set ok=FALSE after write_block_to_device.\n"));
set_jcr_job_status(jcr, JS_ErrorTerminated);
- ok = FALSE;
+ ok = false;
}
}
- Dmsg1(200, "release device JobStatus=%d\n", jcr->JobStatus);
+ if (!ok) {
+ discard_data_spool(jcr);
+ } else {
+ commit_data_spool(jcr);
+ }
+
+ Dmsg1(200, "calling release device JobStatus=%d\n", jcr->JobStatus);
/* Release the device */
- if (!release_device(jcr, dev)) {
+ if (!release_device(jcr)) {
Pmsg0(000, _("Error in release_device\n"));
set_jcr_job_status(jcr, JS_ErrorTerminated);
- ok = FALSE;
+ ok = false;
}
- free_block(block);
-
- if (jcr->spool_attributes && jcr->dir_bsock->spool_fd) {
- bnet_despool(jcr->dir_bsock);
- close_spool_file(jcr, jcr->dir_bsock);
+ if (!ok) {
+ discard_attribute_spool(jcr);
+ } else {
+ commit_attribute_spool(jcr);
}
dir_send_job_status(jcr); /* update director */
projects / bacula / bacula / blobdiff