03Dec05

[bacula/bacula] / bacula / src / stored / device.c

diff --git a/bacula/src/stored/device.c b/bacula/src/stored/device.c
index 282c486354c51b7e2763dcd38dbdd9bf88f6c6ea..d516a6d0e79401fb92dcbd86c7d380eef3841dec 100644 (file)
--- a/bacula/src/stored/device.c
+++ b/bacula/src/stored/device.c
@@ -73,7 +73,6 @@ extern int debug_level;
  */
 bool fixup_device_block_write_error(DCR *dcr)
 {
-   uint32_t stat;
    char PrevVolName[MAX_NAME_LENGTH];
    DEV_BLOCK *label_blk;
    DEV_BLOCK *block = dcr->block;
@@ -84,12 +83,8 @@ bool fixup_device_block_write_error(DCR *dcr)
    DEVICE *dev = dcr->dev;
 
    wait_time = time(NULL);
-   stat = status_dev(dev);
-   if (!(stat & BMT_EOD)) {
-      return false;                    /* this really shouldn't happen */
-   }
 
-   Dmsg0(100, "======= Got EOD ========\n");
+   Dmsg0(100, "Enter fixup_device_block_write_error\n");
 
    block_device(dev, BST_DOING_ACQUIRE);
    /* Unlock, but leave BLOCKED */
@@ -128,7 +123,7 @@ bool fixup_device_block_write_error(DCR *dcr)
    Dmsg0(190, "write label block to dev\n");
    if (!write_block_to_dev(dcr)) {
       berrno be;
-      Pmsg1(0, "write_block_to_device Volume label failed. ERR=%s",
+      Pmsg1(0, _("write_block_to_device Volume label failed. ERR=%s"),
         be.strerror(dev->dev_errno));
       free_block(label_blk);
       dcr->block = block;
@@ -141,8 +136,7 @@ bool fixup_device_block_write_error(DCR *dcr)
    /*
     * Walk through all attached jcrs indicating the volume has changed
     */
-   Dmsg1(100, "Walk attached jcrs. Volume=%s\n", dev->VolCatInfo.VolCatName);
-// for (JCR *mjcr=NULL; (mjcr=next_attached_jcr(dev, mjcr)); ) {
+   Dmsg1(100, "Walk attached dcrs. Volume=%s\n", dev->VolCatInfo.VolCatName);
    DCR *mdcr;
    foreach_dlist(mdcr, dev->attached_dcrs) {
       JCR *mjcr = mdcr->jcr;
@@ -165,7 +159,7 @@ bool fixup_device_block_write_error(DCR *dcr)
    Dmsg0(190, "Write overflow block to dev\n");
    if (!write_block_to_dev(dcr)) {
       berrno be;
-      Pmsg1(0, "write_block_to_device overflow block failed. ERR=%s",
+      Pmsg1(0, _("write_block_to_device overflow block failed. ERR=%s"),
         be.strerror(dev->dev_errno));
       unblock_device(dev);
       return false;                /* device locked */
@@ -246,6 +240,7 @@ void set_new_file_parameters(DCR *dcr)
 bool first_open_device(DCR *dcr)
 {
    DEVICE *dev = dcr->dev;
+   bool ok = true;
 
    Dmsg0(120, "start open_output_device()\n");
    if (!dev) {
@@ -257,28 +252,28 @@ bool first_open_device(DCR *dcr)
    /* Defer opening files */
    if (!dev->is_tape()) {
       Dmsg0(129, "Device is file, deferring open.\n");
-      unlock_device(dev);
-      return true;
+      goto bail_out;
    }
 
     int mode;
     if (dev_cap(dev, CAP_STREAM)) {
        mode = OPEN_WRITE_ONLY;
     } else {
-       mode = OPEN_READ_WRITE;
+       mode = OPEN_READ_ONLY;
     }
    Dmsg0(129, "Opening device.\n");
    dev->open_nowait = true;
    if (dev->open(dcr, mode) < 0) {
       Emsg1(M_FATAL, 0, _("dev open failed: %s\n"), dev->errmsg);
-      dev->open_nowait = false;
-      unlock_device(dev);
-      return false;
+      ok = false;
+      goto bail_out;
    }
    Dmsg1(129, "open dev %s OK\n", dev->print_name());
+
+bail_out:
    dev->open_nowait = false;
    unlock_device(dev);
-   return true;
+   return ok;
 }
 
 /*
@@ -296,10 +291,12 @@ bool open_device(DCR *dcr)
    }
    if (dev->open(dcr, mode) < 0) {
       /* If polling, ignore the error */
+      /* If DVD, also ignore the error, very often you cannot open the device
+       * (when there is no DVD, or when the one inserted is a wrong one) */
       if ((!dev->poll) && (!dev->is_dvd())) {
          Jmsg2(dcr->jcr, M_FATAL, 0, _("Unable to open device %s: ERR=%s\n"),
             dev->print_name(), strerror_dev(dev));
-         Pmsg2(000, "Unable to open archive %s: ERR=%s\n", 
+         Pmsg2(000, _("Unable to open archive %s: ERR=%s\n"), 
             dev->print_name(), strerror_dev(dev));
       }
       return false;
@@ -322,9 +319,7 @@ void close_device(DEVICE *dev)
  */
 void force_close_device(DEVICE *dev)
 {
-   if (!dev) {
-      Mmsg0(dev->errmsg, _("Bad call to force_close_dev. Device not open\n"));
-      Emsg0(M_FATAL, 0, dev->errmsg);
+   if (!dev || dev->fd < 0) {
       return;
    }
    Dmsg1(29, "Force close_dev %s\n", dev->print_name());
@@ -341,7 +336,7 @@ void dev_lock(DEVICE *dev)
 {
    int errstat;
    if ((errstat=rwl_writelock(&dev->lock))) {
-      Emsg1(M_ABORT, 0, "Device write lock failure. ERR=%s\n", strerror(errstat));
+      Emsg1(M_ABORT, 0, _("Device write lock failure. ERR=%s\n"), strerror(errstat));
    }
 }
 
@@ -349,7 +344,7 @@ void dev_unlock(DEVICE *dev)
 {
    int errstat;
    if ((errstat=rwl_writeunlock(&dev->lock))) {
-      Emsg1(M_ABORT, 0, "Device write unlock failure. ERR=%s\n", strerror(errstat));
+      Emsg1(M_ABORT, 0, _("Device write unlock failure. ERR=%s\n"), strerror(errstat));
    }
 }