{
BSOCK *bs = (BSOCK *)arg;
JCR *jcr;
- int i, found, quit;
+ int i;
+ bool found, quit;
int bnet_stat = 0;
char name[MAX_NAME_LENGTH];
if (bnet_recv(bs) <= 0) {
Emsg0(M_ERROR, 0, _("Connection request failed.\n"));
+ bnet_close(bs);
return NULL;
}
*/
if (bs->msglen < 25 || bs->msglen > (int)sizeof(name)-25) {
Emsg1(M_ERROR, 0, _("Invalid Dir connection. Len=%d\n"), bs->msglen);
+ bnet_close(bs);
+ return NULL;
}
/*
* See if this is a File daemon connection. If so
* call FD handler.
*/
- if (sscanf(bs->msg, "Hello Start Job %127s calling\n", name) == 1) {
+ Dmsg1(110, "Conn: %s", bs->msg);
+ if (sscanf(bs->msg, "Hello Start Job %127s", name) == 1) {
handle_filed_connection(bs, name);
return NULL;
}
+ Dmsg0(110, "Start Dir Job\n");
jcr = new_jcr(sizeof(JCR), stored_free_jcr); /* create Job Control Record */
jcr->dir_bsock = bs; /* save Director bsock */
jcr->dir_bsock->jcr = jcr;
+ /* Initialize FD start condition variable */
+ int errstat = pthread_cond_init(&jcr->job_start_wait, NULL);
+ if (errstat != 0) {
+ Jmsg1(jcr, M_FATAL, 0, _("Unable to init job cond variable: ERR=%s\n"), strerror(errstat));
+ free_jcr(jcr);
+ return NULL;
+ }
Dmsg0(1000, "stored in start_job\n");
break; /* connection terminated */
}
Dmsg1(9, "<dird: %s\n", bs->msg);
- found = FALSE;
+ found = false;
for (i=0; cmds[i].cmd; i++) {
if (strncmp(cmds[i].cmd, bs->msg, strlen(cmds[i].cmd)) == 0) {
if (!cmds[i].func(jcr)) { /* do command */
- quit = TRUE; /* error, get out */
+ quit = true; /* error, get out */
Dmsg1(90, "Command %s requsts quit\n", cmds[i].cmd);
}
- found = TRUE; /* indicate command found */
+ found = true; /* indicate command found */
break;
}
}
if (!found) { /* command not found */
bnet_fsend(bs, derrmsg);
- quit = TRUE;
+ quit = true;
break;
}
}
static int setdebug_cmd(JCR *jcr)
{
BSOCK *dir = jcr->dir_bsock;
- int level;
+ int level, trace_flag;
Dmsg1(10, "setdebug_cmd: %s", dir->msg);
- if (sscanf(dir->msg, "setdebug=%d", &level) != 1 || level < 0) {
+ if (sscanf(dir->msg, "setdebug=%d trace=%d", &level, &trace_flag) != 2 || level < 0) {
bnet_fsend(dir, "3991 Bad setdebug command: %s\n", dir->msg);
return 0;
}
debug_level = level;
+ set_trace(trace_flag);
return bnet_fsend(dir, OKsetdebug, level);
}
bsteal_lock_t hold;
steal_device_lock(dev, &hold, BST_WRITING_LABEL);
+ block = new_block(dev);
pm_strcpy(&jcr->VolumeName, newname);
jcr->VolCatInfo.Slot = slot;
- autoload_device(jcr, dev, 0, dir); /* autoload if possible */
- block = new_block(dev);
+ if (autoload_device(jcr, dev, 0, dir) < 0) { /* autoload if possible */
+ goto bail_out;
+ }
/* Ensure that the device is open -- autoload_device() closes it */
for ( ; !(dev->state & ST_OPENED); ) {
- if (open_dev(dev, jcr->VolumeName, READ_WRITE) < 0) {
+ if (open_dev(dev, jcr->VolumeName, OPEN_READ_WRITE) < 0) {
bnet_fsend(dir, _("3910 Unable to open device %s. ERR=%s\n"),
dev_name(dev), strerror_dev(dev));
goto bail_out;
break;
}
}
+ if (found) {
+ jcr->dcr = new_dcr(jcr, device->dev);
+ }
UnlockRes();
return found;
}
case BST_UNMOUNTED_WAITING_FOR_SYSOP:
case BST_UNMOUNTED:
/* We freed the device, so reopen it and wake any waiting threads */
- if (open_dev(dev, NULL, READ_WRITE) < 0) {
+ if (open_dev(dev, NULL, OPEN_READ_WRITE) < 0) {
bnet_fsend(dir, _("3901 open device failed: ERR=%s\n"),
strerror_dev(dev));
break;
bnet_fsend(dir, _("3906 cannot mount non-tape.\n"));
break;
}
- if (open_dev(dev, NULL, READ_WRITE) < 0) {
+ if (open_dev(dev, NULL, OPEN_READ_WRITE) < 0) {
bnet_fsend(dir, _("3901 open device failed: ERR=%s\n"),
strerror_dev(dev));
break;
}
read_label(jcr, dev);
if (dev_state(dev, ST_LABEL)) {
- bnet_fsend(dir, _("3001 Device %s is mounted with Volume \"%s\"\n"),
+ bnet_fsend(dir, _("3001 Device %s is already mounted with Volume \"%s\"\n"),
dev_name(dev), dev->VolHdr.VolName);
} else {
bnet_fsend(dir, _("3905 Device %s open but no Bacula volume is mounted.\n"
P(dev->mutex); /* Use P to avoid indefinite block */
if (!dev_state(dev, ST_OPENED)) {
- if (open_dev(dev, NULL, READ_WRITE) < 0) {
- bnet_fsend(dir, _("3994 Connot open device: %s\n"), strerror_dev(dev));
- } else {
- read_volume_label(jcr, dev, Slot);
- force_close_dev(dev);
- }
+ read_volume_label(jcr, dev, Slot);
+ force_close_dev(dev);
/* Under certain "safe" conditions, we can steal the lock */
} else if (dev->dev_blocked &&
(dev->dev_blocked == BST_UNMOUNTED ||
bsteal_lock_t hold;
steal_device_lock(dev, &hold, BST_WRITING_LABEL);
+ block = new_block(dev);
jcr->VolumeName[0] = 0;
jcr->VolCatInfo.Slot = Slot;
- autoload_device(jcr, dev, 0, dir); /* autoload if possible */
- block = new_block(dev);
+ if (autoload_device(jcr, dev, 0, dir) < 0) { /* autoload if possible */
+ goto bail_out;
+ }
/* Ensure that the device is open -- autoload_device() closes it */
for ( ; !dev_state(dev, ST_OPENED); ) {
- if (open_dev(dev, jcr->VolumeName, READ_WRITE) < 0) {
+ if (open_dev(dev, jcr->VolumeName, OPEN_READ_WRITE) < 0) {
bnet_fsend(dir, _("3910 Unable to open device \"%s\". ERR=%s\n"),
dev_name(dev), strerror_dev(dev));
goto bail_out;
dev->state &= ~ST_LABEL; /* force read of label */
switch (read_dev_volume_label(jcr, dev, block)) {
case VOL_OK:
- bnet_fsend(dir, _("3001 Volume=\"%s\" Slot=%d\n"), dev->VolHdr.VolName, Slot);
+ /* DO NOT add quotes around the Volume name. It is scanned in the DIR */
+ bnet_fsend(dir, _("3001 Volume=%s Slot=%d\n"), dev->VolHdr.VolName, Slot);
Dmsg1(100, "Volume: %s\n", dev->VolHdr.VolName);
break;
default:
projects / bacula / bacula / blobdiff