/*
Bacula® - The Network Backup Solution
- Copyright (C) 2000-2007 Free Software Foundation Europe e.V.
+ Copyright (C) 2000-2009 Free Software Foundation Europe e.V.
The main author of Bacula is Kern Sibbald, with contributions from
many others, a complete list can be found in the file AUTHORS.
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.
- Bacula® is a registered trademark of John Walker.
+ Bacula® is a registered trademark of Kern Sibbald.
The licensor of Bacula is the Free Software Foundation Europe
(FSFE), Fiduciary Program, Sumatrastrasse 25, 8006 Zürich,
Switzerland, email:ftf@fsfeurope.org.
#include "bacula.h"
#include "stored.h"
-#define jid() ((int)get_jobid_from_tid())
+const int dbglvl = 150;
-const int dbglvl = 50;
-
-static dlist *vol_list = NULL;
static brwlock_t reservation_lock;
-static brwlock_t vol_list_lock;
/* Forward referenced functions */
static int can_reserve_drive(DCR *dcr, RCTX &rctx);
static bool use_storage_cmd(JCR *jcr);
static void queue_reserve_message(JCR *jcr);
static void pop_reserve_messages(JCR *jcr);
+//void switch_device(DCR *dcr, DEVICE *dev);
/* Requests from the Director daemon */
static char use_storage[] = "use storage=%127s media_type=%127s "
return true;
}
-static int my_compare(void *item1, void *item2)
-{
- return strcmp(((VOLRES *)item1)->vol_name, ((VOLRES *)item2)->vol_name);
-}
-
-
+/*
+ * This allows a given thread to recursively call lock_reservations.
+ * It must, of course, call unlock_... the same number of times.
+ */
void init_reservations_lock()
{
int errstat;
be.bstrerror(errstat));
}
- if ((errstat=rwl_init(&vol_list_lock)) != 0) {
- berrno be;
- Emsg1(M_ABORT, 0, _("Unable to initialize volume list lock. ERR=%s\n"),
- be.bstrerror(errstat));
- }
+ init_vol_list_lock();
}
void term_reservations_lock()
{
rwl_destroy(&reservation_lock);
- rwl_destroy(&vol_list_lock);
+ term_vol_list_lock();
}
int reservations_lock_count = 0;
}
}
-int vol_list_lock_count = 0;
-
-void _lock_volumes()
-{
- int errstat;
- vol_list_lock_count++;
- if ((errstat=rwl_writelock(&vol_list_lock)) != 0) {
- berrno be;
- Emsg2(M_ABORT, 0, "rwl_writelock failure. stat=%d: ERR=%s\n",
- errstat, be.bstrerror(errstat));
- }
-}
-
-void _unlock_volumes()
-{
- int errstat;
- vol_list_lock_count--;
- if ((errstat=rwl_writeunlock(&vol_list_lock)) != 0) {
- berrno be;
- Emsg2(M_ABORT, 0, "rwl_writeunlock failure. stat=%d: ERR=%s\n",
- errstat, be.bstrerror(errstat));
- }
-}
-
-
-/*
- * List Volumes -- this should be moved to status.c
- */
-enum {
- debug_lock = true,
- debug_nolock = false
-};
-
-static void debug_list_volumes(const char *imsg)
-{
- VOLRES *vol;
- POOL_MEM msg(PM_MESSAGE);
-
- lock_volumes();
- foreach_dlist(vol, vol_list) {
- if (vol->dev) {
- Mmsg(msg, "List from %s: %s at %p on device %s\n", imsg,
- vol->vol_name, vol->vol_name, vol->dev->print_name());
- } else {
- Mmsg(msg, "List from %s: %s at %p no dev\n", imsg, vol->vol_name, vol->vol_name);
- }
- Dmsg2(dbglvl, "jid=%u %s", jid(), msg.c_str());
- }
-
-#ifdef xxx
- DEVICE *dev = NULL;
- foreach_dlist(vol, vol_list) {
- if (vol->dev == dev) {
- Dmsg0(000, "Two Volumes on same device.\n");
- ASSERT(0);
- dev = vol->dev;
- }
- }
-#endif
-
-// Dmsg2(dbglvl, "List from %s: %d volumes\n", imsg, count);
- unlock_volumes();
-}
-
-
-/*
- * List Volumes -- this should be moved to status.c
- */
-void list_volumes(void sendit(const char *msg, int len, void *sarg), void *arg)
-{
- VOLRES *vol;
- POOL_MEM msg(PM_MESSAGE);
- int len;
-
- lock_volumes();
- foreach_dlist(vol, vol_list) {
- DEVICE *dev = vol->dev;
- if (dev) {
- len = Mmsg(msg, "%s on device %s\n", vol->vol_name, dev->print_name());
- sendit(msg.c_str(), len, arg);
- len = Mmsg(msg, " Reader=%d writers=%d reserved=%d\n", dev->can_read()?1:0,
- dev->num_writers, dev->reserved_device);
- sendit(msg.c_str(), len, arg);
- } else {
- len = Mmsg(msg, "%s no dev\n", vol->vol_name);
- sendit(msg.c_str(), len, arg);
- }
- }
- unlock_volumes();
-}
-
-/*
- * Create a Volume item to put in the Volume list
- * Ensure that the device points to it.
- */
-static VOLRES *new_vol_item(DCR *dcr, const char *VolumeName)
-{
- VOLRES *vol;
- vol = (VOLRES *)malloc(sizeof(VOLRES));
- memset(vol, 0, sizeof(VOLRES));
- vol->vol_name = bstrdup(VolumeName);
- vol->dev = dcr->dev;
- Dmsg4(dbglvl, "jid=%u new Vol=%s at %p dev=%s\n", (int)dcr->jcr->JobId,
- VolumeName, vol->vol_name, vol->dev->print_name());
- return vol;
-}
-
-static void free_vol_item(VOLRES *vol)
+void DCR::set_reserved()
{
- free(vol->vol_name);
- if (vol->dev) {
- vol->dev->vol = NULL;
- }
- free(vol);
+ m_reserved = true;
+ Dmsg2(dbglvl, "Inc reserve=%d dev=%s\n", dev->num_reserved(), dev->print_name());
+ dev->inc_reserved();
}
-
-/*
- * Put a new Volume entry in the Volume list. This
- * effectively reserves the volume so that it will
- * not be mounted again.
- *
- * If the device has any current volume associated with it,
- * and it is a different Volume, and the device is not busy,
- * we release the old Volume item and insert the new one.
- *
- * It is assumed that the device is free and locked so that
- * we can change the device structure.
- *
- * Some details of the Volume list handling:
- *
- * 1. The Volume list entry must be attached to the drive (rather than
- * attached to a job as it currently is. I.e. the drive that "owns"
- * the volume (reserved, in use, mounted)
- * must point to the volume (still to be maintained in a list).
- *
- * 2. The Volume is entered in the list when a drive is reserved.
- *
- * 3. When a drive is in use, the device code must appropriately update the
- * volume name as it changes (currently the list is static -- an entry is
- * removed when the Volume is no longer reserved, in use or mounted).
- * The new code must keep the same list entry as long as the drive
- * has any volume associated with it but the volume name in the list
- * must be updated when the drive has a different volume mounted.
- *
- * 4. A job that has reserved a volume, can un-reserve the volume, and if the
- * volume is not mounted, and not reserved, and not in use, it will be
- * removed from the list.
- *
- * 5. If a job wants to reserve a drive with a different Volume from the one on
- * the drive, it can re-use the drive for the new Volume.
- *
- * 6. If a job wants a Volume that is in a different drive, it can either use the
- * other drive or take the volume, only if the other drive is not in use or
- * not reserved.
- *
- * One nice aspect of this is that the reserve use count and the writer use count
- * already exist and are correctly programmed and will need no changes -- use
- * counts are always very tricky.
- *
- * The old code had a concept of "reserving" a Volume, but it needs to be changed
- * to reserving and using a drive. A volume is must be attached to (owned by) a
- * drive and can move from drive to drive or be unused given certain specific
- * conditions of the drive. The key is that the drive must "own" the Volume.
- * The old code has the job (dcr) owning the volume (more or less). The job is
- * to change the insertion and removal of the volumes from the list to be based
- * on the drive rather than the job.
- *
- * Return: VOLRES entry on success
- * NULL volume busy on another drive
- */
-VOLRES *reserve_volume(DCR *dcr, const char *VolumeName)
+void DCR::clear_reserved()
{
- VOLRES *vol, *nvol;
- DEVICE *dev = dcr->dev;
-
- ASSERT(dev != NULL);
-
- Dmsg2(dbglvl, "jid=%u reserve_volume %s\n", jid(), VolumeName);
- /*
- * We lock the reservations system here to ensure
- * when adding a new volume that no newly scheduled
- * job can reserve it.
- */
- lock_volumes();
- debug_list_volumes("begin reserve_volume");
- /*
- * First, remove any old volume attached to this device as it
- * is no longer used.
- */
- if (dev->vol) {
- vol = dev->vol;
- /*
- * Make sure we don't remove the current volume we are inserting
- * because it was probably inserted by another job.
- */
- if (strcmp(vol->vol_name, VolumeName) == 0) {
- goto get_out; /* Volume already on this device */
- } else {
- Dmsg3(dbglvl, "jid=%u reserve_vol free vol=%s at %p\n",
- (int)dcr->jcr->JobId, vol->vol_name, vol->vol_name);
- debug_list_volumes("reserve_vol free");
- vol_list->remove(vol);
- free_vol_item(vol);
- }
+ if (m_reserved) {
+ m_reserved = false;
+ dev->dec_reserved();
+ Dmsg2(dbglvl, "Dec reserve=%d dev=%s\n", dev->num_reserved(), dev->print_name());
}
-
- /* Create a new Volume entry */
- nvol = new_vol_item(dcr, VolumeName);
-
- /*
- * Now try to insert the new Volume
- */
- vol = (VOLRES *)vol_list->binary_insert(nvol, my_compare);
- if (vol != nvol) {
- Dmsg3(dbglvl, "jid=%u Found vol=%s dev-same=%d\n", jid(), vol->vol_name, dev==vol->dev);
- /*
- * At this point, a Volume with this name already is in the list,
- * so we simply release our new Volume entry. Note, this should
- * only happen if we are moving the volume from one drive to another.
- */
- Dmsg3(dbglvl, "jid=%u reserve_vol free-tmp vol=%s at %p\n",
- (int)dcr->jcr->JobId, vol->vol_name, vol->vol_name);
- /*
- * Clear dev pointer so that free_vol_item() doesn't
- * take away our volume.
- */
- nvol->dev = NULL; /* don't zap dev entry */
- free_vol_item(nvol);
-
- /* Check if we are trying to use the Volume on a different drive */
- if (dev != vol->dev) {
- /* Caller wants to switch Volume to another device */
- if (!vol->dev->is_busy()) {
- /* OK to move it -- I'm not sure this will work */
- Dmsg4(dbglvl, "==== jid=%u Swap vol=%s from dev=%s to %s\n", jid(), VolumeName,
- vol->dev->print_name(), dev->print_name());
- vol->dev->vol = NULL; /* take vol from old drive */
- vol->dev->VolHdr.VolumeName[0] = 0;
- vol->dev = dev; /* point vol at new drive */
- dev->vol = vol; /* point dev at vol */
- dev->VolHdr.VolumeName[0] = 0;
- } else {
- Dmsg4(dbglvl, "jid=%u Volume busy could not swap vol=%s from dev=%s to %s\n",
- jid(), VolumeName, vol->dev->print_name(), dev->print_name());
- vol = NULL; /* device busy */
- }
- }
- }
- dev->vol = vol;
-
-get_out:
- debug_list_volumes("end new volume");
- unlock_volumes();
- return vol;
-}
-
-/*
- * Search for a Volume name in the Volume list.
- *
- * Returns: VOLRES entry on success
- * NULL if the Volume is not in the list
- */
-VOLRES *find_volume(DCR *dcr)
-{
- VOLRES vol, *fvol;
- /* Do not lock reservations here */
- lock_volumes();
- vol.vol_name = bstrdup(dcr->VolumeName);
- fvol = (VOLRES *)vol_list->binary_search(&vol, my_compare);
- free(vol.vol_name);
- Dmsg3(dbglvl, "jid=%u find_vol=%s found=%d\n", jid(), dcr->VolumeName, fvol!=NULL);
- debug_list_volumes("find_volume");
- unlock_volumes();
- return fvol;
}
/*
* Remove any reservation from a drive and tell the system
* that the volume is unused at least by us.
*/
-void unreserve_device(DCR *dcr)
+void DCR::unreserve_device()
{
- DEVICE *dev = dcr->dev;
- dev->dlock();
- if (dcr->reserved_device) {
- dcr->reserved_device = false;
- dev->reserved_device--;
- Dmsg3(dbglvl, "jid=%u Dec reserve=%d dev=%s\n", jid(), dev->reserved_device, dev->print_name());
- dcr->reserved_device = false;
+ lock_volumes();
+ if (is_reserved()) {
+ clear_reserved();
+ reserved_volume = false;
/* If we set read mode in reserving, remove it */
if (dev->can_read()) {
dev->clear_read();
}
if (dev->num_writers < 0) {
- Jmsg1(dcr->jcr, M_ERROR, 0, _("Hey! num_writers=%d!!!!\n"), dev->num_writers);
+ Jmsg1(jcr, M_ERROR, 0, _("Hey! num_writers=%d!!!!\n"), dev->num_writers);
dev->num_writers = 0;
}
- }
-
- volume_unused(dcr);
- dev->dunlock();
-}
-
-/*
- * Free a Volume from the Volume list if it is no longer used
- *
- * Returns: true if the Volume found and removed from the list
- * false if the Volume is not in the list or is in use
- */
-bool volume_unused(DCR *dcr)
-{
- DEVICE *dev = dcr->dev;
-
- if (dev->vol == NULL) {
- Dmsg2(dbglvl, "jid=%u vol_unused: no vol on %s\n", (int)dcr->jcr->JobId, dev->print_name());
- debug_list_volumes("null vol cannot unreserve_volume");
- return false;
- }
-
- if (dev->is_busy()) {
- Dmsg2(dbglvl, "jid=%u vol_unused: no vol on %s\n", (int)dcr->jcr->JobId, dev->print_name());
- debug_list_volumes("dev busy cannot unreserve_volume");
- return false;
- }
-
- /*
- * If this is a tape, we do not free the volume, rather we wait
- * until the autoloader unloads it, or until another tape is
- * explicitly read in this drive. This allows the SD to remember
- * where the tapes are or last were.
- */
- if (dev->is_tape() || dev->is_autochanger()) {
- return true;
- } else {
- return free_volume(dev);
- }
-}
-
-/*
- * Unconditionally release the volume
- */
-bool free_volume(DEVICE *dev)
-{
- VOLRES *vol;
-
- if (dev->vol == NULL) {
- Dmsg2(dbglvl, "jid=%u No vol on dev %s\n", jid(), dev->print_name());
- return false;
- }
- lock_volumes();
- vol = dev->vol;
- dev->vol = NULL;
- vol_list->remove(vol);
- Dmsg3(dbglvl, "jid=%u free_volume %s dev=%s\n", jid(), vol->vol_name, dev->print_name());
- free_vol_item(vol);
- debug_list_volumes("free_volume");
- unlock_volumes();
- return vol != NULL;
-}
-
-
-/* Create the Volume list */
-void create_volume_list()
-{
- VOLRES *vol = NULL;
- if (vol_list == NULL) {
- vol_list = New(dlist(vol, &vol->link));
- }
-}
-
-/* Release all Volumes from the list */
-void free_volume_list()
-{
- VOLRES *vol;
- if (!vol_list) {
- return;
- }
- lock_volumes();
- foreach_dlist(vol, vol_list) {
- if (vol->dev) {
- Dmsg3(dbglvl, "jid=%u free vol_list Volume=%s dev=%s\n", jid(),
- vol->vol_name, vol->dev->print_name());
- } else {
- Dmsg3(dbglvl, "jid=%u free vol_list Volume=%s dev=%p\n", jid(),
- vol->vol_name, vol->dev);
+ if (dev->num_reserved() == 0 && dev->num_writers == 0) {
+ volume_unused(this);
}
- free(vol->vol_name);
- vol->vol_name = NULL;
}
- delete vol_list;
- vol_list = NULL;
unlock_volumes();
}
-bool is_volume_in_use(DCR *dcr)
-{
- VOLRES *vol = find_volume(dcr);
- if (!vol) {
- Dmsg2(dbglvl, "jid=%u Vol=%s not in use.\n", jid(), dcr->VolumeName);
- return false; /* vol not in list */
- }
- ASSERT(vol->dev != NULL);
-
- if (dcr->dev == vol->dev) { /* same device OK */
- Dmsg2(dbglvl, "jid=%u Vol=%s on same dev.\n", jid(), dcr->VolumeName);
- return false;
- } else {
- Dmsg4(dbglvl, "jid=%u Vol=%s on %s we have %s\n", jid(), dcr->VolumeName,
- vol->dev->print_name(), dcr->dev->print_name());
- }
- if (!vol->dev->is_busy()) {
- Dmsg3(dbglvl, "jid=%u Vol=%s dev=%s not busy.\n", jid(), dcr->VolumeName, vol->dev->print_name());
- return false;
- } else {
- Dmsg3(dbglvl, "jid=%u Vol=%s dev=%s busy.\n", jid(), dcr->VolumeName, vol->dev->print_name());
- }
- Dmsg3(dbglvl, "jid=%u Vol=%s in use by %s.\n", jid(), dcr->VolumeName, vol->dev->print_name());
- return true;
-}
-
-
/*
* We get the following type of information:
*
dirstore = New(alist(10, not_owned_by_alist));
jcr->reserve_msgs = New(alist(10, not_owned_by_alist));
do {
- Dmsg2(dbglvl, "jid=%u <dird: %s", jid(), dir->msg);
+ Dmsg1(dbglvl, "<dird: %s", dir->msg);
ok = sscanf(dir->msg, use_storage, store_name.c_str(),
media_type.c_str(), pool_name.c_str(),
pool_type.c_str(), &append, &Copy, &Stripe) == 7;
/* Now get all devices */
while (dir->recv() >= 0) {
- Dmsg2(dbglvl, "jid=%u <dird device: %s", jid(), dir->msg);
+ Dmsg1(dbglvl, "<dird device: %s", dir->msg);
ok = sscanf(dir->msg, use_device, dev_name.c_str()) == 1;
if (!ok) {
break;
char *device_name;
if (debug_level >= dbglvl) {
foreach_alist(store, dirstore) {
- Dmsg6(dbglvl, "jid=%u Storage=%s media_type=%s pool=%s pool_type=%s append=%d\n",
- (int)rctx.jcr->JobId,
+ Dmsg5(dbglvl, "Storage=%s media_type=%s pool=%s pool_type=%s append=%d\n",
store->name, store->media_type, store->pool_name,
store->pool_type, store->append);
foreach_alist(device_name, store->device) {
- Dmsg2(dbglvl, "jid=%u Device=%s\n", jid(), device_name);
+ Dmsg1(dbglvl, " Device=%s\n", device_name);
}
}
}
rctx.PreferMountedVols = false;
rctx.exact_match = false;
rctx.autochanger_only = true;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only, rctx.any_drive);
if ((ok = find_suitable_device_for_job(jcr, rctx))) {
break;
}
rctx.try_low_use_drive = false;
}
rctx.autochanger_only = false;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only, rctx.any_drive);
if ((ok = find_suitable_device_for_job(jcr, rctx))) {
break;
}
rctx.PreferMountedVols = true;
rctx.exact_match = true;
rctx.autochanger_only = false;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only, rctx.any_drive);
if ((ok = find_suitable_device_for_job(jcr, rctx))) {
break;
}
/* Look for any mounted drive */
rctx.exact_match = false;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only, rctx.any_drive);
if ((ok = find_suitable_device_for_job(jcr, rctx))) {
break;
}
/* Try any drive */
rctx.any_drive = true;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only, rctx.any_drive);
if ((ok = find_suitable_device_for_job(jcr, rctx))) {
break;
}
*/
if (repeat++ > 1) { /* try algorithm 3 times */
bmicrosleep(30, 0); /* wait a bit */
- Dmsg1(dbglvl, "jid=%u repeat reserve algorithm\n", (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "repeat reserve algorithm\n");
} else if (!rctx.suitable_device || !wait_for_device(jcr, wait_for_device_retries)) {
- Dmsg1(dbglvl, "jid=%u Fail. !suitable_device || !wait_for_device\n",
- (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "Fail. !suitable_device || !wait_for_device\n");
fail = true;
}
lock_reservations();
*/
unbash_spaces(dir->msg);
pm_strcpy(jcr->errmsg, dir->msg);
- Jmsg(jcr, M_INFO, 0, _("Failed command: %s\n"), jcr->errmsg);
- Jmsg(jcr, M_FATAL, 0, _("\n"
- " Device \"%s\" with MediaType \"%s\" requested by DIR not found in SD Device resources.\n"),
- dev_name.c_str(), media_type.c_str());
+ Jmsg(jcr, M_FATAL, 0, _("Device reservation failed for JobId=%d: %s\n"),
+ jcr->JobId, jcr->errmsg);
dir->fsend(NO_device, dev_name.c_str());
- Dmsg2(dbglvl, "jid=%u >dird: %s", jid(), dir->msg);
+ Dmsg1(dbglvl, ">dird: %s", dir->msg);
}
} else {
unbash_spaces(dir->msg);
pm_strcpy(jcr->errmsg, dir->msg);
Jmsg(jcr, M_FATAL, 0, _("Failed command: %s\n"), jcr->errmsg);
dir->fsend(BAD_use, jcr->errmsg);
- Dmsg2(dbglvl, "jid=%u >dird: %s", jid(), dir->msg);
+ Dmsg1(dbglvl, ">dird: %s", dir->msg);
}
release_reserve_messages(jcr);
AUTOCHANGER *changer = vol->dev->device->changer_res;
/* Find resource, and make sure we were able to open it */
- if (fnmatch(rctx.device_name, changer->hdr.name, 0) == 0) {
- Dmsg2(dbglvl, "jid=%u Found changer device %s\n",
- (int)rctx.jcr->JobId, vol->dev->device->hdr.name);
+ if (strcmp(rctx.device_name, changer->hdr.name) == 0) {
+ Dmsg1(dbglvl, "Found changer device %s\n", vol->dev->device->hdr.name);
return true;
}
- Dmsg2(dbglvl, "jid=%u Incorrect changer device %s\n",
- (int)rctx.jcr->JobId, changer->hdr.name);
+ Dmsg1(dbglvl, "Incorrect changer device %s\n", changer->hdr.name);
return false;
}
/*
* Search for a device suitable for this job.
+ * Note, this routine sets sets rctx.suitable_device if any
+ * device exists within the SD. The device may not be actually
+ * useable.
+ * It also returns if it finds a useable device.
*/
bool find_suitable_device_for_job(JCR *jcr, RCTX &rctx)
{
} else {
dirstore = jcr->read_store;
}
- Dmsg5(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d\n",
- (int)rctx.jcr->JobId,
- rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
- rctx.autochanger_only);
+ Dmsg5(dbglvl, "Start find_suit_dev PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
+ rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
+ rctx.autochanger_only, rctx.any_drive);
/*
* If the appropriate conditions of this if are met, namely that
* force try a mounted drive because they are all busy), we
* start by looking at all the Volumes in the volume list.
*/
- if (!vol_list->empty() && rctx.append && rctx.PreferMountedVols) {
- dlist *temp_vol_list, *save_vol_list;
+ if (!is_vol_list_empty() && rctx.append && rctx.PreferMountedVols) {
+ dlist *temp_vol_list;
VOLRES *vol = NULL;
- lock_volumes();
-
- /*
- * Create a temporary copy of the volume list. We do this,
- * to avoid having the volume list locked during the
- * call to reserve_device(), which would cause a deadlock.
- * Note, we may want to add an update counter on the vol_list
- * so that if it is modified while we are traversing the copy
- * we can take note and act accordingly (probably redo the
- * search at least a few times).
- */
- Dmsg1(dbglvl, "jid=%u duplicate vol list\n", (int)rctx.jcr->JobId);
- temp_vol_list = New(dlist(vol, &vol->link));
- foreach_dlist(vol, vol_list) {
- VOLRES *nvol;
- VOLRES *tvol = (VOLRES *)malloc(sizeof(VOLRES));
- memset(tvol, 0, sizeof(VOLRES));
- tvol->vol_name = bstrdup(vol->vol_name);
- tvol->dev = vol->dev;
- nvol = (VOLRES *)temp_vol_list->binary_insert(tvol, my_compare);
- if (tvol != nvol) {
- tvol->dev = NULL; /* don't zap dev entry */
- free_vol_item(tvol);
- Pmsg0(000, "Logic error. Duplicating vol list hit duplicate.\n");
- Jmsg(jcr, M_WARNING, 0, "Logic error. Duplicating vol list hit duplicate.\n");
- }
- }
- unlock_volumes();
+ temp_vol_list = dup_vol_list(jcr);
/* Look through reserved volumes for one we can use */
- Dmsg1(dbglvl, "jid=%u look for vol in vol list\n", (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "look for vol in vol list\n");
foreach_dlist(vol, temp_vol_list) {
if (!vol->dev) {
- Dmsg2(dbglvl, "jid=%u vol=%s no dev\n", (int)rctx.jcr->JobId, vol->vol_name);
+ Dmsg1(dbglvl, "vol=%s no dev\n", vol->vol_name);
continue;
}
/* Check with Director if this Volume is OK */
continue;
}
- Dmsg2(dbglvl, "jid=%u vol=%s OK for this job\n", (int)rctx.jcr->JobId, vol->vol_name);
+ Dmsg1(dbglvl, "vol=%s OK for this job\n", vol->vol_name);
foreach_alist(store, dirstore) {
int stat;
rctx.store = store;
rctx.device = vol->dev->device;
if (vol->dev->is_autochanger()) {
- Dmsg2(dbglvl, "jid=%u vol=%s is in changer\n", (int)rctx.jcr->JobId,
- vol->vol_name);
+ Dmsg1(dbglvl, "vol=%s is in changer\n", vol->vol_name);
if (!is_vol_in_autochanger(rctx, vol)) {
continue;
}
} else if (strcmp(device_name, vol->dev->device->hdr.name) != 0) {
- Dmsg3(dbglvl, "jid=%u device=%s not suitable want %s\n", (int)rctx.jcr->JobId,
+ Dmsg2(dbglvl, "device=%s not suitable want %s\n",
vol->dev->device->hdr.name, device_name);
continue;
}
bstrncpy(rctx.VolumeName, vol->vol_name, sizeof(rctx.VolumeName));
rctx.have_volume = true;
/* Try reserving this device and volume */
- Dmsg3(dbglvl, "jid=%u try vol=%s on device=%s\n", (int)rctx.jcr->JobId,
- rctx.VolumeName, device_name);
+ Dmsg2(dbglvl, "try vol=%s on device=%s\n", rctx.VolumeName, device_name);
stat = reserve_device(rctx);
if (stat == 1) { /* found available device */
- Dmsg2(dbglvl, "jid=%u Suitable device found=%s\n", (int)rctx.jcr->JobId,
- device_name);
+ Dmsg1(dbglvl, "Suitable device found=%s\n", device_name);
ok = true;
break;
} else if (stat == 0) { /* device busy */
- Dmsg2(dbglvl, "jid=%u Suitable device=%s, busy: not use\n",
- (int)rctx.jcr->JobId, device_name);
+ Dmsg1(dbglvl, "Suitable device=%s, busy: not use\n", device_name);
} else {
/* otherwise error */
- Dmsg1(dbglvl, "jid=%u No suitable device found.\n", (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "No suitable device found.\n");
}
rctx.have_volume = false;
+ rctx.VolumeName[0] = 0;
}
if (ok) {
break;
}
} /* end for loop over reserved volumes */
- lock_volumes();
- save_vol_list = vol_list;
- vol_list = temp_vol_list;
- free_volume_list(); /* release temp_vol_list */
- vol_list = save_vol_list;
- Dmsg1(dbglvl, "jid=%u deleted temp vol list\n", (int)rctx.jcr->JobId);
- unlock_volumes();
+ Dmsg0(dbglvl, "lock volumes\n");
+ free_temp_vol_list(temp_vol_list);
}
if (ok) {
- Dmsg2(dbglvl, "jid=%u got vol %s from in-use vols list\n", (int)rctx.jcr->JobId,
- rctx.VolumeName);
+ Dmsg1(dbglvl, "OK dev found. Vol=%s from in-use vols list\n", rctx.VolumeName);
return true;
}
rctx.device_name = device_name;
stat = search_res_for_device(rctx);
if (stat == 1) { /* found available device */
- Dmsg2(dbglvl, "jid=%u available device found=%s\n", (int)rctx.jcr->JobId,
- device_name);
+ Dmsg1(dbglvl, "available device found=%s\n", device_name);
ok = true;
break;
} else if (stat == 0) { /* device busy */
- Dmsg2(dbglvl, "jid=%u Suitable device=%s, busy: not use\n",
- (int)rctx.jcr->JobId, device_name);
+ Dmsg1(dbglvl, "No usable device=%s, busy: not use\n", device_name);
} else {
/* otherwise error */
- Dmsg1(dbglvl, "jid=%u No suitable device found.\n", (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "No usable device found.\n");
}
}
if (ok) {
break;
}
}
+ if (ok) {
+ Dmsg1(dbglvl, "OK dev found. Vol=%s\n", rctx.VolumeName);
+ } else {
+ Dmsg0(dbglvl, "Leave find_suit_dev: no dev found.\n");
+ }
return ok;
}
AUTOCHANGER *changer;
int stat;
- Dmsg2(dbglvl, "jid=%u search res for %s\n", (int)rctx.jcr->JobId, rctx.device_name);
+ Dmsg1(dbglvl, "search res for %s\n", rctx.device_name);
/* Look through Autochangers first */
foreach_res(changer, R_AUTOCHANGER) {
- Dmsg2(dbglvl, "jid=%u Try match changer res=%s\n", (int)rctx.jcr->JobId, changer->hdr.name);
+ Dmsg1(dbglvl, "Try match changer res=%s\n", changer->hdr.name);
/* Find resource, and make sure we were able to open it */
- if (fnmatch(rctx.device_name, changer->hdr.name, 0) == 0) {
+ if (strcmp(rctx.device_name, changer->hdr.name) == 0) {
/* Try each device in this AutoChanger */
foreach_alist(rctx.device, changer->device) {
- Dmsg2(dbglvl, "jid=%u Try changer device %s\n", (int)rctx.jcr->JobId,
- rctx.device->hdr.name);
+ Dmsg1(dbglvl, "Try changer device %s\n", rctx.device->hdr.name);
+ if (!rctx.device->autoselect) {
+ Dmsg1(100, "Device %s not autoselect skipped.\n",
+ rctx.device->hdr.name);
+ continue; /* device is not available */
+ }
stat = reserve_device(rctx);
if (stat != 1) { /* try another device */
continue;
}
/* Debug code */
if (rctx.store->append == SD_APPEND) {
- Dmsg3(dbglvl, "jid=%u Device %s reserved=%d for append.\n",
- (int)rctx.jcr->JobId, rctx.device->hdr.name,
- rctx.jcr->dcr->dev->reserved_device);
+ Dmsg2(dbglvl, "Device %s reserved=%d for append.\n",
+ rctx.device->hdr.name, rctx.jcr->dcr->dev->num_reserved());
} else {
- Dmsg3(dbglvl, "jid=%u Device %s reserved=%d for read.\n",
- (int)rctx.jcr->JobId, rctx.device->hdr.name,
- rctx.jcr->read_dcr->dev->reserved_device);
+ Dmsg2(dbglvl, "Device %s reserved=%d for read.\n",
+ rctx.device->hdr.name, rctx.jcr->read_dcr->dev->num_reserved());
}
return stat;
}
/* Now if requested look through regular devices */
if (!rctx.autochanger_only) {
foreach_res(rctx.device, R_DEVICE) {
- Dmsg2(dbglvl, "jid=%u Try match res=%s\n", (int)rctx.jcr->JobId, rctx.device->hdr.name);
+ Dmsg1(dbglvl, "Try match res=%s\n", rctx.device->hdr.name);
/* Find resource, and make sure we were able to open it */
- if (fnmatch(rctx.device_name, rctx.device->hdr.name, 0) == 0) {
+ if (strcmp(rctx.device_name, rctx.device->hdr.name) == 0) {
stat = reserve_device(rctx);
if (stat != 1) { /* try another device */
continue;
}
/* Debug code */
if (rctx.store->append == SD_APPEND) {
- Dmsg3(dbglvl, "jid=%u Device %s reserved=%d for append.\n",
- (int)rctx.jcr->JobId, rctx.device->hdr.name,
- rctx.jcr->dcr->dev->reserved_device);
+ Dmsg2(dbglvl, "Device %s reserved=%d for append.\n",
+ rctx.device->hdr.name, rctx.jcr->dcr->dev->num_reserved());
} else {
- Dmsg3(dbglvl, "jid=%u Device %s reserved=%d for read.\n",
- (int)rctx.jcr->JobId, rctx.device->hdr.name,
- rctx.jcr->read_dcr->dev->reserved_device);
+ Dmsg2(dbglvl, "Device %s reserved=%d for read.\n",
+ rctx.device->hdr.name, rctx.jcr->read_dcr->dev->num_reserved());
}
return stat;
}
const int name_len = MAX_NAME_LENGTH;
/* Make sure MediaType is OK */
- Dmsg3(dbglvl, "jid=%u chk MediaType device=%s request=%s\n",
- (int)rctx.jcr->JobId,
+ Dmsg2(dbglvl, "chk MediaType device=%s request=%s\n",
rctx.device->media_type, rctx.store->media_type);
if (strcmp(rctx.device->media_type, rctx.store->media_type) != 0) {
return -1;
}
rctx.suitable_device = true;
- Dmsg2(dbglvl, "jid=%u try reserve %s\n", rctx.jcr->JobId, rctx.device->hdr.name);
+ Dmsg1(dbglvl, "try reserve %s\n", rctx.device->hdr.name);
rctx.jcr->dcr = dcr = new_dcr(rctx.jcr, rctx.jcr->dcr, rctx.device->dev);
if (!dcr) {
BSOCK *dir = rctx.jcr->dir_bsock;
bstrncpy(dcr->media_type, rctx.store->media_type, name_len);
bstrncpy(dcr->dev_name, rctx.device_name, name_len);
if (rctx.store->append == SD_APPEND) {
- Dmsg3(dbglvl, "jid=%u have_vol=%d vol=%s\n", (int)rctx.jcr->JobId,
- rctx.have_volume, rctx.VolumeName);
+ Dmsg2(dbglvl, "call reserve for append: have_vol=%d vol=%s\n", rctx.have_volume, rctx.VolumeName);
ok = reserve_device_for_append(dcr, rctx);
if (!ok) {
goto bail_out;
}
rctx.jcr->dcr = dcr;
- Dmsg6(dbglvl, "jid=%u Reserved=%d dev_name=%s mediatype=%s pool=%s ok=%d\n",
- (int)rctx.jcr->JobId,
- dcr->dev->reserved_device,
+ Dmsg5(dbglvl, "Reserved=%d dev_name=%s mediatype=%s pool=%s ok=%d\n",
+ dcr->dev->num_reserved(),
dcr->dev_name, dcr->media_type, dcr->pool_name, ok);
- if (!rctx.have_volume) {
+ Dmsg3(dbglvl, "Vol=%s num_writers=%d, have_vol=%d\n",
+ rctx.VolumeName, dcr->dev->num_writers, rctx.have_volume);
+ if (rctx.have_volume) {
+ Dmsg0(dbglvl, "Call reserve_volume\n");
+ if (reserve_volume(dcr, rctx.VolumeName)) {
+ Dmsg1(dbglvl, "Reserved vol=%s\n", rctx.VolumeName);
+ } else {
+ Dmsg1(dbglvl, "Could not reserve vol=%s\n", rctx.VolumeName);
+ goto bail_out;
+ }
+ } else {
dcr->any_volume = true;
+ Dmsg0(dbglvl, "no vol, call find_next_appendable_vol.\n");
if (dir_find_next_appendable_volume(dcr)) {
bstrncpy(rctx.VolumeName, dcr->VolumeName, sizeof(rctx.VolumeName));
- Dmsg2(dbglvl, "jid=%u looking for Volume=%s\n", (int)rctx.jcr->JobId, rctx.VolumeName);
rctx.have_volume = true;
+ Dmsg1(dbglvl, "looking for Volume=%s\n", rctx.VolumeName);
} else {
- Dmsg1(dbglvl, "jid=%u No next volume found\n", (int)rctx.jcr->JobId);
+ Dmsg0(dbglvl, "No next volume found\n");
rctx.have_volume = false;
rctx.VolumeName[0] = 0;
/*
* non-used drive and our one and only volume is mounted
* elsewhere, so we bail out and retry using that drive.
*/
- if (dcr->volume_in_use && !rctx.PreferMountedVols) {
+ if (dcr->found_in_use() && !rctx.PreferMountedVols) {
rctx.PreferMountedVols = true;
+ if (dcr->VolumeName[0]) {
+ dcr->unreserve_device();
+ }
+ goto bail_out;
+ }
+ /*
+ * Note. Under some circumstances, the Director can hand us
+ * a Volume name that is not the same as the one on the current
+ * drive, and in that case, the call above to find the next
+ * volume will fail because in attempting to reserve the Volume
+ * the code will realize that we already have a tape mounted,
+ * and it will fail. This *should* only happen if there are
+ * writers, thus the following test. In that case, we simply
+ * bail out, and continue waiting, rather than plunging on
+ * and hoping that the operator can resolve the problem.
+ */
+ if (dcr->dev->num_writers != 0) {
+ if (dcr->VolumeName[0]) {
+ dcr->unreserve_device();
+ }
goto bail_out;
}
}
ok = reserve_device_for_read(dcr);
if (ok) {
rctx.jcr->read_dcr = dcr;
- Dmsg6(dbglvl, "jid=%u Read reserved=%d dev_name=%s mediatype=%s pool=%s ok=%d\n",
- (int)rctx.jcr->JobId,
- dcr->dev->reserved_device,
+ Dmsg5(dbglvl, "Read reserved=%d dev_name=%s mediatype=%s pool=%s ok=%d\n",
+ dcr->dev->num_reserved(),
dcr->dev_name, dcr->media_type, dcr->pool_name, ok);
}
}
if (!ok) {
goto bail_out;
}
+
if (rctx.notify_dir) {
POOL_MEM dev_name;
BSOCK *dir = rctx.jcr->dir_bsock;
pm_strcpy(dev_name, rctx.device->hdr.name);
bash_spaces(dev_name);
ok = dir->fsend(OK_device, dev_name.c_str()); /* Return real device name */
- Dmsg2(dbglvl, "jid=%u >dird changer: %s", jid(), dir->msg);
+ Dmsg1(dbglvl, ">dird: %s", dir->msg);
} else {
ok = true;
}
bail_out:
rctx.have_volume = false;
-// free_dcr(dcr);
- Dmsg1(dbglvl, "jid=%u Not OK.\n", (int)rctx.jcr->JobId);
+ rctx.VolumeName[0] = 0;
+ Dmsg0(dbglvl, "Not OK.\n");
return 0;
}
bool ok = false;
ASSERT(dcr);
+ if (job_canceled(jcr)) {
+ return false;
+ }
dev->dlock();
- if (is_device_unmounted(dev)) {
- Dmsg2(dbglvl, "jid=%u Device %s is BLOCKED due to user unmount.\n",
- (int)jcr->JobId, dev->print_name());
+ if (dev->is_device_unmounted()) {
+ Dmsg1(dbglvl, "Device %s is BLOCKED due to user unmount.\n", dev->print_name());
Mmsg(jcr->errmsg, _("3601 JobId=%u device %s is BLOCKED due to user unmount.\n"),
jcr->JobId, dev->print_name());
queue_reserve_message(jcr);
}
if (dev->is_busy()) {
- Dmsg5(dbglvl, "jid=%u Device %s is busy ST_READ=%d num_writers=%d reserved=%d.\n",
- (int)jcr->JobId, dev->print_name(),
- dev->state & ST_READ?1:0, dev->num_writers, dev->reserved_device);
+ Dmsg4(dbglvl, "Device %s is busy ST_READ=%d num_writers=%d reserved=%d.\n",
+ dev->print_name(),
+ dev->state & ST_READ?1:0, dev->num_writers, dev->num_reserved());
Mmsg(jcr->errmsg, _("3602 JobId=%u device %s is busy (already reading/writing).\n"),
jcr->JobId, dev->print_name());
queue_reserve_message(jcr);
dev->clear_append();
dev->set_read();
ok = true;
- dev->reserved_device++;
- Dmsg4(dbglvl, "jid=%u Inc reserve=%d dev=%s %p\n", (int)jcr->JobId,
- dev->reserved_device, dev->print_name(), dev);
- dcr->reserved_device = true;
+ dcr->set_reserved();
bail_out:
dev->dunlock();
/*
- * We reserve the device for appending by incrementing the
- * reserved_device. We do virtually all the same work that
+ * We reserve the device for appending by incrementing
+ * num_reserved(). We do virtually all the same work that
* is done in acquire_device_for_append(), but we do
* not attempt to mount the device. This routine allows
* the DIR to reserve multiple devices before *really*
bool ok = false;
ASSERT(dcr);
+ if (job_canceled(jcr)) {
+ return false;
+ }
dev->dlock();
if (dev->can_read()) {
Mmsg(jcr->errmsg, _("3603 JobId=%u device %s is busy reading.\n"),
jcr->JobId, dev->print_name());
- Dmsg2(dbglvl, "jid=%u %s", jid(), jcr->errmsg);
+ Dmsg1(dbglvl, "%s", jcr->errmsg);
queue_reserve_message(jcr);
goto bail_out;
}
/* If device is unmounted, we are out of luck */
- if (is_device_unmounted(dev)) {
+ if (dev->is_device_unmounted()) {
Mmsg(jcr->errmsg, _("3604 JobId=%u device %s is BLOCKED due to user unmount.\n"),
jcr->JobId, dev->print_name());
- Dmsg2(dbglvl, "jid=%u %s", jid(), jcr->errmsg);
+ Dmsg1(dbglvl, "%s", jcr->errmsg);
queue_reserve_message(jcr);
goto bail_out;
}
- Dmsg2(dbglvl, "jid=%u reserve_append device is %s\n",
- (int)jcr->JobId, dev->print_name());
+ Dmsg1(dbglvl, "reserve_append device is %s\n", dev->print_name());
/* Now do detailed tests ... */
if (can_reserve_drive(dcr, rctx) != 1) {
- Dmsg1(dbglvl, "jid=%u can_reserve_drive!=1\n", (int)jcr->JobId);
+ Dmsg0(dbglvl, "can_reserve_drive!=1\n");
goto bail_out;
}
- dev->reserved_device++;
- Dmsg4(dbglvl, "jid=%u Inc reserve=%d dev=%s %p\n", (int)jcr->JobId, dev->reserved_device,
- dev->print_name(), dev);
- dcr->reserved_device = true;
+ dcr->set_reserved();
ok = true;
bail_out:
return ok;
}
+static int is_pool_ok(DCR *dcr)
+{
+ DEVICE *dev = dcr->dev;
+ JCR *jcr = dcr->jcr;
+
+ /* Now check if we want the same Pool and pool type */
+ if (strcmp(dev->pool_name, dcr->pool_name) == 0 &&
+ strcmp(dev->pool_type, dcr->pool_type) == 0) {
+ /* OK, compatible device */
+ Dmsg1(dbglvl, "OK dev: %s num_writers=0, reserved, pool matches\n", dev->print_name());
+ return 1;
+ } else {
+ /* Drive Pool not suitable for us */
+ Mmsg(jcr->errmsg, _(
+"3608 JobId=%u wants Pool=\"%s\" but have Pool=\"%s\" nreserve=%d on drive %s.\n"),
+ (uint32_t)jcr->JobId, dcr->pool_name, dev->pool_name,
+ dev->num_reserved(), dev->print_name());
+ queue_reserve_message(jcr);
+ Dmsg2(dbglvl, "failed: busy num_writers=0, reserved, pool=%s wanted=%s\n",
+ dev->pool_name, dcr->pool_name);
+ }
+ return 0;
+}
+
+static bool is_max_jobs_ok(DCR *dcr)
+{
+ DEVICE *dev = dcr->dev;
+ JCR *jcr = dcr->jcr;
+
+ Dmsg5(dbglvl, "MaxJobs=%d Jobs=%d reserves=%d Status=%s Vol=%s\n",
+ dcr->VolCatInfo.VolCatMaxJobs,
+ dcr->VolCatInfo.VolCatJobs, dev->num_reserved(),
+ dcr->VolCatInfo.VolCatStatus,
+ dcr->VolumeName);
+ /* Limit max concurrent jobs on this drive */
+ if (dev->max_concurrent_jobs > 0 && dev->max_concurrent_jobs <=
+ (uint32_t)(dev->num_writers + dev->num_reserved())) {
+ /* Max Concurrent Jobs depassed or already reserved */
+ Mmsg(jcr->errmsg, _("3609 JobId=%u Max concurrent jobs exceeded on drive %s.\n"),
+ (uint32_t)jcr->JobId, dev->print_name());
+ queue_reserve_message(jcr);
+ Dmsg1(dbglvl, "reserve dev failed: %s", jcr->errmsg);
+ return false;
+ }
+ if (strcmp(dcr->VolCatInfo.VolCatStatus, "Recycle") == 0) {
+ return true;
+ }
+ if (dcr->VolCatInfo.VolCatMaxJobs > 0 && dcr->VolCatInfo.VolCatMaxJobs <=
+ (dcr->VolCatInfo.VolCatJobs + dev->num_reserved())) {
+ /* Max Job Vols depassed or already reserved */
+ Mmsg(jcr->errmsg, _("3610 JobId=%u Volume max jobs exceeded on drive %s.\n"),
+ (uint32_t)jcr->JobId, dev->print_name());
+ queue_reserve_message(jcr);
+ Dmsg1(dbglvl, "reserve dev failed: %s", jcr->errmsg);
+ return false; /* wait */
+ }
+ return true;
+}
+
/*
* Returns: 1 if drive can be reserved
* 0 if we should wait
DEVICE *dev = dcr->dev;
JCR *jcr = dcr->jcr;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)jcr->JobId,
+ Dmsg5(dbglvl, "PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
rctx.autochanger_only, rctx.any_drive);
+ /* Check for max jobs on this Volume */
+ if (!is_max_jobs_ok(dcr)) {
+ return 0;
+ }
+
/* setting any_drive overrides PreferMountedVols flag */
if (!rctx.any_drive) {
/*
* helps spread the load to the least used drives.
*/
if (rctx.try_low_use_drive && dev == rctx.low_use_drive) {
- Dmsg3(dbglvl, "jid=%u OK dev=%s == low_drive=%s.\n",
- jcr->JobId, dev->print_name(), rctx.low_use_drive->print_name());
+ Dmsg2(dbglvl, "OK dev=%s == low_drive=%s.\n",
+ dev->print_name(), rctx.low_use_drive->print_name());
return 1;
}
/* If he wants a free drive, but this one is busy, no go */
if (!rctx.PreferMountedVols && dev->is_busy()) {
/* Save least used drive */
- if ((dev->num_writers + dev->reserved_device) < rctx.num_writers) {
- rctx.num_writers = dev->num_writers + dev->reserved_device;
+ if ((dev->num_writers + dev->num_reserved()) < rctx.num_writers) {
+ rctx.num_writers = dev->num_writers + dev->num_reserved();
rctx.low_use_drive = dev;
- Dmsg3(dbglvl, "jid=%u set low use drive=%s num_writers=%d\n",
- (int)jcr->JobId, dev->print_name(), rctx.num_writers);
+ Dmsg2(dbglvl, "set low use drive=%s num_writers=%d\n",
+ dev->print_name(), rctx.num_writers);
} else {
- Dmsg2(dbglvl, "jid=%u not low use num_writers=%d\n",
- (int)jcr->JobId, dev->num_writers+dev->reserved_device);
+ Dmsg1(dbglvl, "not low use num_writers=%d\n", dev->num_writers+dev->num_reserved());
}
- Dmsg1(dbglvl, "jid=%u failed: !prefMnt && busy.\n", jcr->JobId);
+ Dmsg0(dbglvl, "failed: !prefMnt && busy.\n");
Mmsg(jcr->errmsg, _("3605 JobId=%u wants free drive but device %s is busy.\n"),
jcr->JobId, dev->print_name());
queue_reserve_message(jcr);
Mmsg(jcr->errmsg, _("3606 JobId=%u prefers mounted drives, but drive %s has no Volume.\n"),
jcr->JobId, dev->print_name());
queue_reserve_message(jcr);
- Dmsg1(dbglvl, "jid=%u failed: want mounted -- no vol\n", (uint32_t)jcr->JobId);
+ Dmsg0(dbglvl, "failed: want mounted -- no vol\n");
return 0; /* No volume mounted */
}
*/
if (rctx.exact_match && rctx.have_volume) {
bool ok;
- Dmsg6(dbglvl, "jid=%u PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
- (int)jcr->JobId,
+ Dmsg5(dbglvl, "PrefMnt=%d exact=%d suitable=%d chgronly=%d any=%d\n",
rctx.PreferMountedVols, rctx.exact_match, rctx.suitable_device,
rctx.autochanger_only, rctx.any_drive);
- Dmsg5(dbglvl, "jid=%u have_vol=%d have=%s resvol=%s want=%s\n",
- (int)jcr->JobId, rctx.have_volume, dev->VolHdr.VolumeName,
+ Dmsg4(dbglvl, "have_vol=%d have=%s resvol=%s want=%s\n",
+ rctx.have_volume, dev->VolHdr.VolumeName,
dev->vol?dev->vol->vol_name:"*none*", rctx.VolumeName);
ok = strcmp(dev->VolHdr.VolumeName, rctx.VolumeName) == 0 ||
(dev->vol && strcmp(dev->vol->vol_name, rctx.VolumeName) == 0);
jcr->JobId, rctx.VolumeName, dev->VolHdr.VolumeName,
dev->print_name());
queue_reserve_message(jcr);
- Dmsg4(dbglvl, "jid=%u not OK: dev have=%s resvol=%s want=%s\n",
- (int)jcr->JobId, dev->VolHdr.VolumeName,
- dev->vol?dev->vol->vol_name:"*none*", rctx.VolumeName);
+ Dmsg3(dbglvl, "not OK: dev have=%s resvol=%s want=%s\n",
+ dev->VolHdr.VolumeName, dev->vol?dev->vol->vol_name:"*none*", rctx.VolumeName);
return 0;
}
- if (is_volume_in_use(dcr)) {
+ if (!dcr->can_i_use_volume()) {
return 0; /* fail if volume on another drive */
}
}
if (rctx.autochanger_only && !dev->is_busy() &&
dev->VolHdr.VolumeName[0] == 0) {
/* Device is available but not yet reserved, reserve it for us */
- Dmsg2(dbglvl, "jid=%u OK Res Unused autochanger %s.\n",
- jcr->JobId, dev->print_name());
+ Dmsg1(dbglvl, "OK Res Unused autochanger %s.\n", dev->print_name());
bstrncpy(dev->pool_name, dcr->pool_name, sizeof(dev->pool_name));
bstrncpy(dev->pool_type, dcr->pool_type, sizeof(dev->pool_type));
return 1; /* reserve drive */
*/
if (dev->num_writers == 0) {
/* Now check if there are any reservations on the drive */
- if (dev->reserved_device) {
- /* Now check if we want the same Pool and pool type */
- if (strcmp(dev->pool_name, dcr->pool_name) == 0 &&
- strcmp(dev->pool_type, dcr->pool_type) == 0) {
- /* OK, compatible device */
- Dmsg2(dbglvl, "jid=%u OK dev: %s num_writers=0, reserved, pool matches\n",
- jcr->JobId, dev->print_name());
- return 1;
- } else {
- /* Drive Pool not suitable for us */
- Mmsg(jcr->errmsg, _(
-"3608 JobId=%u wants Pool=\"%s\" but have Pool=\"%s\" nreserve=%d on drive %s.\n"),
- jcr->JobId, dcr->pool_name, dev->pool_name,
- dev->reserved_device, dev->print_name());
- queue_reserve_message(jcr);
- Dmsg3(dbglvl, "jid=%u failed: busy num_writers=0, reserved, pool=%s wanted=%s\n",
- (int)jcr->JobId, dev->pool_name, dcr->pool_name);
- return 0; /* wait */
- }
+ if (dev->num_reserved()) {
+ return is_pool_ok(dcr);
} else if (dev->can_append()) {
- /* Device in append mode, check if changing pool */
- if (strcmp(dev->pool_name, dcr->pool_name) == 0 &&
- strcmp(dev->pool_type, dcr->pool_type) == 0) {
- Dmsg2(dbglvl, "jid=%u OK dev: %s num_writers=0, can_append, pool matches.\n",
- jcr->JobId, dev->print_name());
- /* OK, compatible device */
- return 1;
+ if (is_pool_ok(dcr)) {
+ return 1;
} else {
/* Changing pool, unload old tape if any in drive */
- Dmsg1(dbglvl, "jid=%u OK dev: num_writers=0, not reserved, pool change, unload changer\n",
- (int)jcr->JobId);
- unload_autochanger(dcr, 0);
+ Dmsg0(dbglvl, "OK dev: num_writers=0, not reserved, pool change, unload changer\n");
+ /* ***FIXME*** use set_unload() */
+ unload_autochanger(dcr, -1);
}
}
/* Device is available but not yet reserved, reserve it for us */
- Dmsg2(dbglvl, "jid=%u OK Dev avail reserved %s\n", jcr->JobId, dev->print_name());
+ Dmsg1(dbglvl, "OK Dev avail reserved %s\n", dev->print_name());
bstrncpy(dev->pool_name, dcr->pool_name, sizeof(dev->pool_name));
bstrncpy(dev->pool_type, dcr->pool_type, sizeof(dev->pool_type));
return 1; /* reserve drive */
* available if pool is the same).
*/
if (dev->can_append() || dev->num_writers > 0) {
- /* Yes, now check if we want the same Pool and pool type */
- if (strcmp(dev->pool_name, dcr->pool_name) == 0 &&
- strcmp(dev->pool_type, dcr->pool_type) == 0) {
- Dmsg2(dbglvl, "jid=%u OK dev: %s num_writers>=0, can_append, pool matches.\n",
- jcr->JobId, dev->print_name());
- /* OK, compatible device */
- return 1;
- } else {
- /* Drive Pool not suitable for us */
- Mmsg(jcr->errmsg, _("3609 JobId=%u wants Pool=\"%s\" but has Pool=\"%s\" on drive %s.\n"),
- jcr->JobId, dcr->pool_name, dev->pool_name, dev->print_name());
- queue_reserve_message(jcr);
- Dmsg3(dbglvl, "jid=%u failed: busy num_writers>0, can_append, pool=%s wanted=%s\n",
- (int)jcr->JobId, dev->pool_name, dcr->pool_name);
- return 0; /* wait */
- }
+ return is_pool_ok(dcr);
} else {
Pmsg1(000, _("Logic error!!!! JobId=%u Should not get here.\n"), (int)jcr->JobId);
Mmsg(jcr->errmsg, _("3910 JobId=%u Logic error!!!! drive %s Should not get here.\n"),
Mmsg(jcr->errmsg, _("3911 JobId=%u failed reserve drive %s.\n"),
jcr->JobId, dev->print_name());
queue_reserve_message(jcr);
- Dmsg2(dbglvl, "jid=%u failed: No reserve %s\n", jcr->JobId, dev->print_name());
+ Dmsg1(dbglvl, "failed: No reserve %s\n", dev->print_name());
return 0;
}