+/*
+ Bacula(R) - The Network Backup Solution
+
+ Copyright (C) 2000-2016 Kern Sibbald
+
+ The original author of Bacula is Kern Sibbald, with contributions
+ from many others, a complete list can be found in the file AUTHORS.
+
+ You may use this file and others of this release according to the
+ license defined in the LICENSE file, which includes the Affero General
+ Public License, v3.0 ("AGPLv3") and some additional permissions and
+ terms pursuant to its AGPLv3 Section 7.
+
+ This notice must be preserved when any source code is
+ conveyed and/or propagated.
+
+ Bacula(R) is a registered trademark of Kern Sibbald.
+*/
/*
*
* Program to check a Bacula database for consistency and to
*
* Kern E. Sibbald, August 2002
*
- * Version $Id$
- *
- */
-/*
- Copyright (C) 2002-2005 Kern Sibbald
-
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License
- version 2 as amended with additional clauses defined in the
- file LICENSE in the main source directory.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- the file LICENSE for additional details.
-
*/
#include "bacula.h"
#include "cats/cats.h"
+#include "lib/runscript.h"
#include "dird/dird_conf.h"
-/* Dummy functions */
-int generate_daemon_event(JCR *jcr, const char *event)
- { return 1; }
+extern bool parse_dir_config(CONFIG *config, const char *configfile, int exit_code);
typedef struct s_id_ctx {
- uint32_t *Id; /* ids to be modified */
+ int64_t *Id; /* ids to be modified */
int num_ids; /* ids stored */
int max_ids; /* size of array */
int num_del; /* number deleted */
int tot_ids; /* total to process */
} NAME_LIST;
+/* Global variables */
-
-/* Global variables */
static bool fix = false;
static bool batch = false;
-static B_DB *db;
+static BDB *db;
static ID_LIST id_list;
static NAME_LIST name_list;
-static char buf[2000];
+static char buf[20000];
+static bool quit = false;
+static CONFIG *config;
+static const char *idx_tmp_name;
#define MAX_ID_LIST_LEN 10000000
-/* Forward referenced functions */
+/* Forward referenced functions */
static int make_id_list(const char *query, ID_LIST *id_list);
static int delete_id_list(const char *query, ID_LIST *id_list);
static int make_name_list(const char *query, NAME_LIST *name_list);
static void repair_bad_paths();
static void repair_bad_filenames();
static void do_interactive_mode();
-static int yes_no(const char *prompt);
-
+static bool yes_no(const char *prompt);
+static bool check_idx(const char *col_name);
+static bool create_tmp_idx(const char *idx_name, const char *table_name,
+ const char *col_name);
+static bool drop_tmp_idx(const char *idx_name, const char *table_name);
+static int check_idx_handler(void *ctx, int num_fields, char **row);
static void usage()
{
fprintf(stderr,
-"Usage: dbcheck [-c config] [-C catalog name] [-d debug_level] <working-directory> <bacula-database> <user> <password> [<dbhost>]\n"
+PROG_COPYRIGHT
+"\n%sVersion: %s (%s)\n\n"
+"Usage: dbcheck [-c config ] [-B] [-C catalog name] [-d debug_level] <working-directory> <bacula-database> <user> <password> [<dbhost>] [<dbport>] [<dbport>] [<dbsslmode>] [<dbsslkey>] [<dbsslcert>] [<dbsslca>]\n"
" -b batch mode\n"
" -C catalog name in the director conf file\n"
-" -c director conf filename\n"
-" -dnn set debug level to nn\n"
+" -c Director conf filename\n"
+" -B print catalog configuration and exit\n"
+" -d <nn> set debug level to <nn>\n"
+" -dt print a timestamp in debug output\n"
" -f fix inconsistencies\n"
+" -t test if client library is thread-safe\n"
" -v verbose\n"
-" -? print this message\n\n");
+" -? print this message\n"
+"\n", 2002, "", VERSION, BDATE);
+
exit(1);
}
{
int ch;
const char *user, *password, *db_name, *dbhost;
+ const char *dbsslmode = NULL, *dbsslkey = NULL, *dbsslcert = NULL, *dbsslca = NULL;
+ const char *dbsslcapath = NULL, *dbsslcipher = NULL;
+ int dbport = 0;
+ bool print_catalog=false;
char *configfile = NULL;
char *catalogname = NULL;
+ char *endptr;
setlocale(LC_ALL, "");
bindtextdomain("bacula", LOCALEDIR);
textdomain("bacula");
+ lmgr_init_thread();
my_name_is(argc, argv, "dbcheck");
- init_msg(NULL, NULL); /* setup message handler */
+ init_msg(NULL, NULL); /* setup message handler */
memset(&id_list, 0, sizeof(id_list));
memset(&name_list, 0, sizeof(name_list));
-
- while ((ch = getopt(argc, argv, "bc:C:d:fv?")) != -1) {
+ while ((ch = getopt(argc, argv, "bc:C:d:fvB?")) != -1) {
switch (ch) {
+ case 'B':
+ print_catalog = true; /* get catalog information from config */
+ break;
case 'b': /* batch */
batch = true;
break;
-
case 'C': /* CatalogName */
catalogname = optarg;
break;
-
case 'c': /* configfile */
configfile = optarg;
break;
-
case 'd': /* debug level */
- debug_level = atoi(optarg);
- if (debug_level <= 0)
- debug_level = 1;
+ if (*optarg == 't') {
+ dbg_timestamp = true;
+ } else {
+ debug_level = atoi(optarg);
+ if (debug_level <= 0) {
+ debug_level = 1;
+ }
+ }
break;
-
case 'f': /* fix inconsistencies */
fix = true;
break;
-
case 'v':
verbose++;
break;
-
case '?':
default:
usage();
argc -= optind;
argv += optind;
+ OSDependentInit();
+
if (configfile) {
CAT *catalog = NULL;
int found = 0;
if (argc > 0) {
Pmsg0(0, _("Warning skipping the additional parameters for working directory/dbname/user/password/host.\n"));
}
- parse_config(configfile);
+ config = New(CONFIG());
+ parse_dir_config(config, configfile, M_ERROR_TERM);
LockRes();
foreach_res(catalog, R_CATALOG) {
if (catalogname && !strcmp(catalog->hdr.name, catalogname)) {
exit(1);
}
set_working_directory(director->working_directory);
+
+ /* Print catalog information and exit (-B) */
+ if (print_catalog) {
+
+ POOLMEM *catalog_details = get_pool_memory(PM_MESSAGE);
+ db = db_init_database(NULL, catalog->db_driver, catalog->db_name, catalog->db_user,
+ catalog->db_password, catalog->db_address,
+ catalog->db_port, catalog->db_socket,
+ catalog->db_ssl_mode,
+ catalog->db_ssl_key, catalog->db_ssl_cert,
+ catalog->db_ssl_ca,
+ catalog->db_ssl_capath, catalog->db_ssl_cipher,
+ catalog->mult_db_connections,
+ catalog->disable_batch_insert);
+ if (db) {
+ printf("%sdb_type=%s\nworking_dir=%s\n", catalog->display(catalog_details),
+ db_get_engine_name(db), working_directory);
+ db_close_database(NULL, db);
+ }
+ free_pool_memory(catalog_details);
+ exit(0);
+ }
+
db_name = catalog->db_name;
user = catalog->db_user;
password = catalog->db_password;
if (dbhost && dbhost[0] == 0) {
dbhost = NULL;
}
+ dbport = catalog->db_port;
+ dbsslmode = catalog->db_ssl_mode;
+ dbsslkey = catalog->db_ssl_key;
+ dbsslcert = catalog->db_ssl_cert;
+ dbsslca = catalog->db_ssl_ca;
+ dbsslcapath = catalog->db_ssl_capath;
+ dbsslcipher = catalog->db_ssl_cipher;
}
} else {
- if (argc > 5) {
+ if (argc > 10) {
Pmsg0(0, _("Wrong number of arguments.\n"));
usage();
}
password = "";
dbhost = NULL;
- if (argc == 2) {
+ if (argc >= 2) {
db_name = argv[1];
user = db_name;
- } else if (argc == 3) {
- db_name = argv[1];
- user = argv[2];
- } else if (argc == 4) {
- db_name = argv[1];
- user = argv[2];
- password = argv[3];
- } else if (argc == 5) {
- db_name = argv[1];
- user = argv[2];
- password = argv[3];
- dbhost = argv[4];
- }
+ if (argc >= 3) {
+ user = argv[2];
+ if (argc >= 4) {
+ password = argv[3];
+ if (argc >= 5) {
+ dbhost = argv[4];
+ if (argc >= 6) {
+ errno = 0;
+ dbport = strtol(argv[5], &endptr, 10);
+ if (*endptr != '\0') {
+ Pmsg0(0, _("Database port must be a numeric value.\n"));
+ exit(1);
+ } else if (errno == ERANGE) {
+ Pmsg0(0, _("Database port must be a int value.\n"));
+ exit(1);
+ }
+ if (argc >= 7) {
+ dbsslmode = argv[6];
+ if (argc >= 8) {
+ dbsslkey = argv[7];
+ dbsslcert = argv[8];
+ if (argc == 10) {
+ dbsslca = argv[9];
+ } /* if (argc == 10) */
+ } /* if (argc >= 8) */
+ } /* if (argc >= 7) */
+ } /* if (argc >= 6) */
+ } /* if (argc >= 5) */
+ } /* if (argc >= 4) */
+ } /* if (argc >= 3) */
+ } /* if (argc >= 2) */
}
/* Open database */
- db = db_init_database(NULL, db_name, user, password, dbhost, 0, NULL, 0);
- if (!db_open_database(NULL, db)) {
+ db = db_init_database(NULL, NULL, db_name, user, password, dbhost,
+ dbport, NULL, dbsslmode, dbsslkey, dbsslcert, dbsslca,
+ dbsslcapath, dbsslcipher, false, false);
+
+ if (!db || !db_open_database(NULL, db)) {
Emsg1(M_FATAL, 0, "%s", db_strerror(db));
return 1;
}
+ /* Drop temporary index idx_tmp_name if it already exists */
+ drop_tmp_idx("idxPIchk", "File");
+
if (batch) {
repair_bad_paths();
repair_bad_filenames();
do_interactive_mode();
}
- db_close_database(NULL, db);
+ /* Drop temporary index idx_tmp_name */
+ drop_tmp_idx("idxPIchk", "File");
+
+ if (db) db_close_database(NULL, db);
close_msg(NULL);
term_msg();
+ lmgr_cleanup_main();
return 0;
}
+void print_catalog_details(CAT *catalog, const char *working_dir)
+{
+ POOLMEM *catalog_details = get_pool_memory(PM_MESSAGE);
+
+ /*
+ * Instantiate a BDB class and see what db_type gets assigned to it.
+ */
+ db = db_init_database(NULL, catalog->db_driver, catalog->db_name, catalog->db_user,
+ catalog->db_password, catalog->db_address,
+ catalog->db_port, catalog->db_socket,
+ catalog->db_ssl_mode, catalog->db_ssl_key,
+ catalog->db_ssl_cert, catalog->db_ssl_ca,
+ catalog->db_ssl_capath, catalog->db_ssl_cipher,
+ catalog->mult_db_connections,
+ catalog->disable_batch_insert);
+ if (db) {
+ printf("%sdb_type=%s\nworking_dir=%s\n", catalog->display(catalog_details),
+ db_get_engine_name(db), working_directory);
+ db_close_database(NULL, db);
+ }
+ free_pool_memory(catalog_details);
+}
+
static void do_interactive_mode()
{
- bool quit = false;
const char *cmd;
printf(_("Hello, this is the database check/correct program.\n"));
else
printf(_(" Verbose is off.\n"));
- printf(_("Please select the fuction you want to perform.\n"));
+ printf(_("Please select the function you want to perform.\n"));
while (!quit) {
if (fix) {
return 0;
}
-
static int print_jobmedia_handler(void *ctx, int num_fields, char **row)
{
printf(_("Orphaned JobMediaId=%s JobId=%s Volume=\"%s\"\n"),
return 0;
}
-
/*
* Called here with each id to be added to the list
*/
}
if (lst->num_ids == lst->max_ids) {
if (lst->max_ids == 0) {
- lst->max_ids = 1000;
- lst->Id = (uint32_t *)bmalloc(sizeof(uint32_t) * lst->max_ids);
+ lst->max_ids = 10000;
+ lst->Id = (int64_t *)bmalloc(sizeof(int64_t) * lst->max_ids);
} else {
lst->max_ids = (lst->max_ids * 3) / 2;
- lst->Id = (uint32_t *)brealloc(lst->Id, sizeof(uint32_t) * lst->max_ids);
+ lst->Id = (int64_t *)brealloc(lst->Id, sizeof(int64_t) * lst->max_ids);
}
}
- lst->Id[lst->num_ids++] = (uint32_t)strtod(row[0], NULL);
+ lst->Id[lst->num_ids++] = str_to_int64(row[0]);
return 0;
}
*/
static int delete_id_list(const char *query, ID_LIST *id_list)
{
+ char ed1[50];
for (int i=0; i < id_list->num_ids; i++) {
- bsnprintf(buf, sizeof(buf), query, id_list->Id[i]);
+ bsnprintf(buf, sizeof(buf), query, edit_int64(id_list->Id[i], ed1));
if (verbose) {
printf(_("Deleting: %s\n"), buf);
}
}
if (name->num_ids == name->max_ids) {
if (name->max_ids == 0) {
- name->max_ids = 1000;
+ name->max_ids = 10000;
name->name = (char **)bmalloc(sizeof(char *) * name->max_ids);
} else {
name->max_ids = (name->max_ids * 3) / 2;
return 0;
}
-
/*
* Construct name list
*/
}
}
-
/*
* Free names in the list
*/
if (name_list.num_ids && verbose && yes_no(_("Print the list? (yes/no): "))) {
print_name_list(&name_list);
}
+ if (quit) {
+ return;
+ }
if (fix) {
/* Loop through list of duplicate names */
for (int i=0; i<name_list.num_ids; i++) {
/* Get all the Ids of each name */
- db_escape_string(esc_name, name_list.name[i], strlen(name_list.name[i]));
+ db_escape_string(NULL, db, esc_name, name_list.name[i], strlen(name_list.name[i]));
bsnprintf(buf, sizeof(buf), "SELECT FilenameId FROM Filename WHERE Name='%s'", esc_name);
if (verbose > 1) {
printf("%s\n", buf);
}
/* Force all records to use the first id then delete the other ids */
for (int j=1; j<id_list.num_ids; j++) {
- bsnprintf(buf, sizeof(buf), "UPDATE File SET FilenameId=%u WHERE FilenameId=%u",
- id_list.Id[0], id_list.Id[j]);
+ char ed1[50], ed2[50];
+ bsnprintf(buf, sizeof(buf), "UPDATE File SET FilenameId=%s WHERE FilenameId=%s",
+ edit_int64(id_list.Id[0], ed1), edit_int64(id_list.Id[j], ed2));
if (verbose > 1) {
printf("%s\n", buf);
}
db_sql_query(db, buf, NULL, NULL);
- bsnprintf(buf, sizeof(buf), "DELETE FROM Filename WHERE FilenameId=%u",
- id_list.Id[j]);
+ bsnprintf(buf, sizeof(buf), "DELETE FROM Filename WHERE FilenameId=%s",
+ ed2);
if (verbose > 2) {
printf("%s\n", buf);
}
printf(_("Checking for duplicate Path entries.\n"));
/* Make list of duplicated names */
-
query = "SELECT Path, count(Path) as Count FROM Path "
"GROUP BY Path HAVING count(Path) > 1";
if (name_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
print_name_list(&name_list);
}
+ if (quit) {
+ return;
+ }
if (fix) {
/* Loop through list of duplicate names */
for (int i=0; i<name_list.num_ids; i++) {
/* Get all the Ids of each name */
- db_escape_string(esc_name, name_list.name[i], strlen(name_list.name[i]));
+ db_escape_string(NULL, db, esc_name, name_list.name[i], strlen(name_list.name[i]));
bsnprintf(buf, sizeof(buf), "SELECT PathId FROM Path WHERE Path='%s'", esc_name);
if (verbose > 1) {
printf("%s\n", buf);
}
/* Force all records to use the first id then delete the other ids */
for (int j=1; j<id_list.num_ids; j++) {
- bsnprintf(buf, sizeof(buf), "UPDATE File SET PathId=%u WHERE PathId=%u",
- id_list.Id[0], id_list.Id[j]);
+ char ed1[50], ed2[50];
+ bsnprintf(buf, sizeof(buf), "UPDATE File SET PathId=%s WHERE PathId=%s",
+ edit_int64(id_list.Id[0], ed1), edit_int64(id_list.Id[j], ed2));
if (verbose > 1) {
printf("%s\n", buf);
}
db_sql_query(db, buf, NULL, NULL);
- bsnprintf(buf, sizeof(buf), "DELETE FROM Path WHERE PathId=%u",
- id_list.Id[j]);
+ bsnprintf(buf, sizeof(buf), "DELETE FROM Path WHERE PathId=%s", ed2);
if (verbose > 2) {
printf("%s\n", buf);
}
static void eliminate_orphaned_jobmedia_records()
{
- const char *query;
+ const char *query = "SELECT JobMedia.JobMediaId,Job.JobId FROM JobMedia "
+ "LEFT OUTER JOIN Job ON (JobMedia.JobId=Job.JobId) "
+ "WHERE Job.JobId IS NULL LIMIT 300000";
printf(_("Checking for orphaned JobMedia entries.\n"));
- query = "SELECT JobMedia.JobMediaId,Job.JobId FROM JobMedia "
- "LEFT OUTER JOIN Job ON (JobMedia.JobId=Job.JobId) "
- "WHERE Job.JobId IS NULL";
if (!make_id_list(query, &id_list)) {
exit(1);
}
- printf(_("Found %d orphaned JobMedia records.\n"), id_list.num_ids);
- if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
- for (int i=0; i < id_list.num_ids; i++) {
- bsnprintf(buf, sizeof(buf),
+ /* Loop doing 300000 at a time */
+ while (id_list.num_ids != 0) {
+ printf(_("Found %d orphaned JobMedia records.\n"), id_list.num_ids);
+ if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
+ for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
+ bsnprintf(buf, sizeof(buf),
"SELECT JobMedia.JobMediaId,JobMedia.JobId,Media.VolumeName FROM JobMedia,Media "
-"WHERE JobMedia.JobMediaId=%u AND Media.MediaId=JobMedia.MediaId", id_list.Id[i]);
- if (!db_sql_query(db, buf, print_jobmedia_handler, NULL)) {
- printf("%s\n", db_strerror(db));
+ "WHERE JobMedia.JobMediaId=%s AND Media.MediaId=JobMedia.MediaId",
+ edit_int64(id_list.Id[i], ed1));
+ if (!db_sql_query(db, buf, print_jobmedia_handler, NULL)) {
+ printf("%s\n", db_strerror(db));
+ }
}
}
- }
+ if (quit) {
+ return;
+ }
- if (fix && id_list.num_ids > 0) {
- printf(_("Deleting %d orphaned JobMedia records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM JobMedia WHERE JobMediaId=%u", &id_list);
+ if (fix && id_list.num_ids > 0) {
+ printf(_("Deleting %d orphaned JobMedia records.\n"), id_list.num_ids);
+ delete_id_list("DELETE FROM JobMedia WHERE JobMediaId=%s", &id_list);
+ } else {
+ break; /* get out if not updating db */
+ }
+ if (!make_id_list(query, &id_list)) {
+ exit(1);
+ }
}
}
static void eliminate_orphaned_file_records()
{
- const char *query;
+ const char *query = "SELECT File.FileId,Job.JobId FROM File "
+ "LEFT OUTER JOIN Job ON (File.JobId=Job.JobId) "
+ "WHERE Job.JobId IS NULL LIMIT 300000";
printf(_("Checking for orphaned File entries. This may take some time!\n"));
- query = "SELECT File.FileId,Job.JobId FROM File "
- "LEFT OUTER JOIN Job ON (File.JobId=Job.JobId) "
- "WHERE Job.JobId IS NULL";
if (verbose > 1) {
printf("%s\n", query);
}
if (!make_id_list(query, &id_list)) {
exit(1);
}
- printf(_("Found %d orphaned File records.\n"), id_list.num_ids);
- if (name_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
- for (int i=0; i < id_list.num_ids; i++) {
- bsnprintf(buf, sizeof(buf),
+ /* Loop doing 300000 at a time */
+ while (id_list.num_ids != 0) {
+ printf(_("Found %d orphaned File records.\n"), id_list.num_ids);
+ if (name_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
+ for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
+ bsnprintf(buf, sizeof(buf),
"SELECT File.FileId,File.JobId,Filename.Name FROM File,Filename "
-"WHERE File.FileId=%u AND File.FilenameId=Filename.FilenameId", id_list.Id[i]);
- if (!db_sql_query(db, buf, print_file_handler, NULL)) {
- printf("%s\n", db_strerror(db));
+ "WHERE File.FileId=%s AND File.FilenameId=Filename.FilenameId",
+ edit_int64(id_list.Id[i], ed1));
+ if (!db_sql_query(db, buf, print_file_handler, NULL)) {
+ printf("%s\n", db_strerror(db));
+ }
}
}
- }
-
- if (fix && id_list.num_ids > 0) {
- printf(_("Deleting %d orphaned File records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM File WHERE FileId=%u", &id_list);
+ if (quit) {
+ return;
+ }
+ if (fix && id_list.num_ids > 0) {
+ printf(_("Deleting %d orphaned File records.\n"), id_list.num_ids);
+ delete_id_list("DELETE FROM File WHERE FileId=%s", &id_list);
+ } else {
+ break; /* get out if not updating db */
+ }
+ if (!make_id_list(query, &id_list)) {
+ exit(1);
+ }
}
}
static void eliminate_orphaned_path_records()
{
- const char *query;
+ db_int64_ctx lctx;
+ lctx.count=0;
+ db_sql_query(db, "SELECT 1 FROM Job WHERE HasCache=1 LIMIT 1",
+ db_int64_handler, &lctx);
+
+ if (lctx.count == 1) {
+ printf(_("Pruning orphaned Path entries isn't possible when using BVFS.\n"));
+ return;
+ }
+
+ idx_tmp_name = NULL;
+ /* Check the existence of the required "one column" index */
+ if (!check_idx("PathId")) {
+ if (yes_no(_("Create temporary index? (yes/no): "))) {
+ /* create temporary index PathId */
+ create_tmp_idx("idxPIchk", "File", "PathId");
+ }
+ }
+
+ const char *query = "SELECT DISTINCT Path.PathId,File.PathId FROM Path "
+ "LEFT OUTER JOIN File ON (Path.PathId=File.PathId) "
+ "WHERE File.PathId IS NULL LIMIT 300000";
printf(_("Checking for orphaned Path entries. This may take some time!\n"));
- query = "SELECT DISTINCT Path.PathId,File.PathId FROM Path "
- "LEFT OUTER JOIN File ON (Path.PathId=File.PathId) "
- "WHERE File.PathId IS NULL";
if (verbose > 1) {
printf("%s\n", query);
}
if (!make_id_list(query, &id_list)) {
exit(1);
}
- printf(_("Found %d orphaned Path records.\n"), id_list.num_ids);
- if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
- for (int i=0; i < id_list.num_ids; i++) {
- bsnprintf(buf, sizeof(buf), "SELECT Path FROM Path WHERE PathId=%u", id_list.Id[i]);
- db_sql_query(db, buf, print_name_handler, NULL);
+ /* Loop doing 300000 at a time */
+ while (id_list.num_ids != 0) {
+ printf(_("Found %d orphaned Path records.\n"), id_list.num_ids);
+ if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
+ for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
+ bsnprintf(buf, sizeof(buf), "SELECT Path FROM Path WHERE PathId=%s",
+ edit_int64(id_list.Id[i], ed1));
+ db_sql_query(db, buf, print_name_handler, NULL);
+ }
}
- }
-
- if (fix && id_list.num_ids > 0) {
- printf(_("Deleting %d orphaned Path records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Path WHERE PathId=%u", &id_list);
- }
+ if (quit) {
+ return;
+ }
+ if (fix && id_list.num_ids > 0) {
+ printf(_("Deleting %d orphaned Path records.\n"), id_list.num_ids);
+ delete_id_list("DELETE FROM Path WHERE PathId=%s", &id_list);
+ } else {
+ break; /* get out if not updating db */
+ }
+ if (!make_id_list(query, &id_list)) {
+ exit(1);
+ }
+ }
+ /* Drop temporary index idx_tmp_name */
+ drop_tmp_idx("idxPIchk", "File");
}
static void eliminate_orphaned_filename_records()
{
- const char *query;
+ idx_tmp_name = NULL;
+ /* Check the existence of the required "one column" index */
+ if (!check_idx("FilenameId") ) {
+ if (yes_no(_("Create temporary index? (yes/no): "))) {
+ /* Create temporary index FilenameId */
+ create_tmp_idx("idxFIchk", "File", "FilenameId");
+ }
+ }
+
+ const char *query = "SELECT Filename.FilenameId,File.FilenameId FROM Filename "
+ "LEFT OUTER JOIN File ON (Filename.FilenameId=File.FilenameId) "
+ "WHERE File.FilenameId IS NULL LIMIT 300000";
printf(_("Checking for orphaned Filename entries. This may take some time!\n"));
- query = "SELECT Filename.FilenameId,File.FilenameId FROM Filename "
- "LEFT OUTER JOIN File ON (Filename.FilenameId=File.FilenameId) "
- "WHERE File.FilenameId IS NULL";
if (verbose > 1) {
printf("%s\n", query);
}
if (!make_id_list(query, &id_list)) {
exit(1);
}
- printf(_("Found %d orphaned Filename records.\n"), id_list.num_ids);
- if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
- for (int i=0; i < id_list.num_ids; i++) {
- bsnprintf(buf, sizeof(buf), "SELECT Name FROM Filename WHERE FilenameId=%u", id_list.Id[i]);
- db_sql_query(db, buf, print_name_handler, NULL);
+ /* Loop doing 300000 at a time */
+ while (id_list.num_ids != 0) {
+ printf(_("Found %d orphaned Filename records.\n"), id_list.num_ids);
+ if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
+ for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
+ bsnprintf(buf, sizeof(buf), "SELECT Name FROM Filename WHERE FilenameId=%s",
+ edit_int64(id_list.Id[i], ed1));
+ db_sql_query(db, buf, print_name_handler, NULL);
+ }
+ }
+ if (quit) {
+ return;
+ }
+ if (fix && id_list.num_ids > 0) {
+ printf(_("Deleting %d orphaned Filename records.\n"), id_list.num_ids);
+ delete_id_list("DELETE FROM Filename WHERE FilenameId=%s", &id_list);
+ } else {
+ break; /* get out if not updating db */
+ }
+ if (!make_id_list(query, &id_list)) {
+ exit(1);
}
}
+ /* Drop temporary index idx_tmp_name */
+ drop_tmp_idx("idxFIchk", "File");
- if (fix && id_list.num_ids > 0) {
- printf(_("Deleting %d orphaned Filename records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Filename WHERE FilenameId=%u", &id_list);
- }
}
static void eliminate_orphaned_fileset_records()
printf(_("Found %d orphaned FileSet records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf), "SELECT FileSetId,FileSet,MD5 FROM FileSet "
- "WHERE FileSetId=%u", id_list.Id[i]);
+ "WHERE FileSetId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_fileset_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
printf(_("Deleting %d orphaned FileSet records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM FileSet WHERE FileSetId=%u", &id_list);
+ delete_id_list("DELETE FROM FileSet WHERE FileSetId=%s", &id_list);
}
}
printf(_("Found %d orphaned Client records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf), "SELECT ClientId,Name FROM Client "
- "WHERE ClientId=%u", id_list.Id[i]);
+ "WHERE ClientId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_client_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
printf(_("Deleting %d orphaned Client records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Client WHERE ClientId=%u", &id_list);
+ delete_id_list("DELETE FROM Client WHERE ClientId=%s", &id_list);
}
}
printf(_("Found %d orphaned Job records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf), "SELECT JobId,Name,StartTime FROM Job "
- "WHERE JobId=%u", id_list.Id[i]);
+ "WHERE JobId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_job_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
printf(_("Deleting %d orphaned Job records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Job WHERE JobId=%u", &id_list);
+ delete_id_list("DELETE FROM Job WHERE JobId=%s", &id_list);
+ printf(_("Deleting JobMedia records of orphaned Job records.\n"));
+ delete_id_list("DELETE FROM JobMedia WHERE JobId=%s", &id_list);
+ printf(_("Deleting Log records of orphaned Job records.\n"));
+ delete_id_list("DELETE FROM Log WHERE JobId=%s", &id_list);
}
}
-
static void eliminate_admin_records()
{
const char *query;
printf(_("Found %d Admin Job records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf), "SELECT JobId,Name,StartTime FROM Job "
- "WHERE JobId=%u", id_list.Id[i]);
+ "WHERE JobId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_job_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
printf(_("Deleting %d Admin Job records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Job WHERE JobId=%u", &id_list);
+ delete_id_list("DELETE FROM Job WHERE JobId=%s", &id_list);
}
}
printf(_("Found %d Restore Job records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (int i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf), "SELECT JobId,Name,StartTime FROM Job "
- "WHERE JobId=%u", id_list.Id[i]);
+ "WHERE JobId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_job_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
printf(_("Deleting %d Restore Job records.\n"), id_list.num_ids);
- delete_id_list("DELETE FROM Job WHERE JobId=%u", &id_list);
+ delete_id_list("DELETE FROM Job WHERE JobId=%s", &id_list);
}
}
-
-
-
static void repair_bad_filenames()
{
const char *query;
printf(_("Found %d bad Filename records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf),
- "SELECT Name FROM Filename WHERE FilenameId=%u", id_list.Id[i]);
+ "SELECT Name FROM Filename WHERE FilenameId=%s",
+ edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_name_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
POOLMEM *name = get_pool_memory(PM_FNAME);
char esc_name[5000];
printf(_("Reparing %d bad Filename records.\n"), id_list.num_ids);
for (i=0; i < id_list.num_ids; i++) {
int len;
+ char ed1[50];
bsnprintf(buf, sizeof(buf),
- "SELECT Name FROM Filename WHERE FilenameId=%u", id_list.Id[i]);
+ "SELECT Name FROM Filename WHERE FilenameId=%s",
+ edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, get_name_handler, name)) {
printf("%s\n", db_strerror(db));
}
/* Strip trailing slash(es) */
- for (len=strlen(name); len > 0 && name[len-1]=='/'; len--)
+ for (len=strlen(name); len > 0 && IsPathSeparator(name[len-1]); len--)
{ }
if (len == 0) {
len = 1;
esc_name[1] = 0;
} else {
name[len-1] = 0;
- db_escape_string(esc_name, name, len);
+ db_escape_string(NULL, db, esc_name, name, len);
}
bsnprintf(buf, sizeof(buf),
- "UPDATE Filename SET Name='%s' WHERE FilenameId=%u",
- esc_name, id_list.Id[i]);
+ "UPDATE Filename SET Name='%s' WHERE FilenameId=%s",
+ esc_name, edit_int64(id_list.Id[i], ed1));
if (verbose > 1) {
printf("%s\n", buf);
}
db_sql_query(db, buf, NULL, NULL);
}
+ free_pool_memory(name);
}
}
printf(_("Found %d bad Path records.\n"), id_list.num_ids);
if (id_list.num_ids && verbose && yes_no(_("Print them? (yes/no): "))) {
for (i=0; i < id_list.num_ids; i++) {
+ char ed1[50];
bsnprintf(buf, sizeof(buf),
- "SELECT Path FROM Path WHERE PathId=%u", id_list.Id[i]);
+ "SELECT Path FROM Path WHERE PathId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, print_name_handler, NULL)) {
printf("%s\n", db_strerror(db));
}
}
}
-
+ if (quit) {
+ return;
+ }
if (fix && id_list.num_ids > 0) {
POOLMEM *name = get_pool_memory(PM_FNAME);
char esc_name[5000];
printf(_("Reparing %d bad Filename records.\n"), id_list.num_ids);
for (i=0; i < id_list.num_ids; i++) {
int len;
+ char ed1[50];
bsnprintf(buf, sizeof(buf),
- "SELECT Path FROM Path WHERE PathId=%u", id_list.Id[i]);
+ "SELECT Path FROM Path WHERE PathId=%s", edit_int64(id_list.Id[i], ed1));
if (!db_sql_query(db, buf, get_name_handler, name)) {
printf("%s\n", db_strerror(db));
}
}
/* Add trailing slash */
len = pm_strcat(&name, "/");
- db_escape_string(esc_name, name, len);
- bsnprintf(buf, sizeof(buf), "UPDATE Path SET Path='%s' WHERE PathId=%u",
- esc_name, id_list.Id[i]);
+ db_escape_string(NULL, db, esc_name, name, len);
+ bsnprintf(buf, sizeof(buf), "UPDATE Path SET Path='%s' WHERE PathId=%s",
+ esc_name, edit_int64(id_list.Id[i], ed1));
if (verbose > 1) {
printf("%s\n", buf);
}
db_sql_query(db, buf, NULL, NULL);
}
+ free_pool_memory(name);
}
}
-
/*
* Gen next input command from the terminal
*/
static char cmd[1000];
printf("%s", prompt);
- if (fgets(cmd, sizeof(cmd), stdin) == NULL)
+ if (fgets(cmd, sizeof(cmd), stdin) == NULL) {
+ printf("\n");
+ quit = true;
return NULL;
- printf("\n");
+ }
strip_trailing_junk(cmd);
return cmd;
}
-static int yes_no(const char *prompt)
+static bool yes_no(const char *prompt)
{
char *cmd;
cmd = get_cmd(prompt);
+ if (!cmd) {
+ quit = true;
+ return false;
+ }
return (strcasecmp(cmd, "yes") == 0) || (strcasecmp(cmd, _("yes")) == 0);
}
bool python_set_prog(JCR*, char const*) { return false; }
+
+/*
+ * The code below to add indexes is needed only for MySQL, and
+ * that to improve the performance.
+ */
+
+#define MAXIDX 100
+typedef struct s_idx_list {
+ char *key_name;
+ int count_key; /* how many times the index meets *key_name */
+ int count_col; /* how many times meets the desired column name */
+} IDX_LIST;
+
+static IDX_LIST idx_list[MAXIDX];
+
+/*
+ * Called here with each table index to be added to the list
+ */
+static int check_idx_handler(void *ctx, int num_fields, char **row)
+{
+ /*
+ * Table | Non_unique | Key_name | Seq_in_index | Column_name |...
+ * File | 0 | PRIMARY | 1 | FileId |...
+ */
+ char *name, *key_name, *col_name;
+ int i, len;
+ int found = false;
+
+ name = (char *)ctx;
+ key_name = row[2];
+ col_name = row[4];
+ for(i = 0; (idx_list[i].key_name != NULL) && (i < MAXIDX); i++) {
+ if (strcasecmp(idx_list[i].key_name, key_name) == 0 ) {
+ idx_list[i].count_key++;
+ found = true;
+ if (strcasecmp(col_name, name) == 0) {
+ idx_list[i].count_col++;
+ }
+ break;
+ }
+ }
+ /* If the new Key_name, add it to the list */
+ if (!found) {
+ len = strlen(key_name) + 1;
+ idx_list[i].key_name = (char *)malloc(len);
+ bstrncpy(idx_list[i].key_name, key_name, len);
+ idx_list[i].count_key = 1;
+ if (strcasecmp(col_name, name) == 0) {
+ idx_list[i].count_col = 1;
+ } else {
+ idx_list[i].count_col = 0;
+ }
+ }
+ return 0;
+}
+
+/*
+ * Return TRUE if "one column" index over *col_name exists
+ */
+static bool check_idx(const char *col_name)
+{
+ int i;
+ int found = false;
+ const char *query = "SHOW INDEX FROM File";
+
+ if (db_get_type_index(db) != SQL_TYPE_MYSQL) {
+ return true;
+ }
+ /* Continue for MySQL */
+ memset(&idx_list, 0, sizeof(idx_list));
+ if (!db_sql_query(db, query, check_idx_handler, (void *)col_name)) {
+ printf("%s\n", db_strerror(db));
+ }
+ for (i = 0; (idx_list[i].key_name != NULL) && (i < MAXIDX) ; i++) {
+ /*
+ * NOTE : if (idx_list[i].count_key > 1) then index idx_list[i].key_name is "multiple-column" index
+ */
+ if ((idx_list[i].count_key == 1) && (idx_list[i].count_col == 1)) {
+ /* "one column" index over *col_name found */
+ found = true;
+ }
+ }
+ if (found) {
+ if (verbose) {
+ printf(_("Ok. Index over the %s column already exists and dbcheck will work faster.\n"), col_name);
+ }
+ } else {
+ printf(_("Note. Index over the %s column not found, that can greatly slow down dbcheck.\n"), col_name);
+ }
+ return found;
+}
+
+/*
+ * Create temporary one-column index
+ */
+static bool create_tmp_idx(const char *idx_name, const char *table_name,
+ const char *col_name)
+{
+ idx_tmp_name = NULL;
+ printf(_("Create temporary index... This may take some time!\n"));
+ bsnprintf(buf, sizeof(buf), "CREATE INDEX %s ON %s (%s)", idx_name, table_name, col_name);
+ if (verbose) {
+ printf("%s\n", buf);
+ }
+ if (db_sql_query(db, buf, NULL, NULL)) {
+ idx_tmp_name = idx_name;
+ if (verbose) {
+ printf(_("Temporary index created.\n"));
+ }
+ } else {
+ printf("%s\n", db_strerror(db));
+ return false;
+ }
+ return true;
+}
+
+/*
+ * Drop temporary index
+ */
+static bool drop_tmp_idx(const char *idx_name, const char *table_name)
+{
+ if (idx_tmp_name != NULL) {
+ printf(_("Drop temporary index.\n"));
+ bsnprintf(buf, sizeof(buf), "DROP INDEX %s ON %s", idx_name, table_name);
+ if (verbose) {
+ printf("%s\n", buf);
+ }
+ if (!db_sql_query(db, buf, NULL, NULL)) {
+ printf("%s\n", db_strerror(db));
+ return false;
+ } else {
+ if (verbose) {
+ printf(_("Temporary index %s deleted.\n"), idx_tmp_name);
+ }
+ }
+ }
+ idx_tmp_name = NULL;
+ return true;
+}
projects / bacula / bacula / blobdiff