/*
- *
+ Bacula(R) - The Network Backup Solution
+
+ Copyright (C) 2000-2017 Kern Sibbald
+
+ The original author of Bacula is Kern Sibbald, with contributions
+ from many others, a complete list can be found in the file AUTHORS.
+
+ You may use this file and others of this release according to the
+ license defined in the LICENSE file, which includes the Affero General
+ Public License, v3.0 ("AGPLv3") and some additional permissions and
+ terms pursuant to its AGPLv3 Section 7.
+
+ This notice must be preserved when any source code is
+ conveyed and/or propagated.
+
+ Bacula(R) is a registered trademark of Kern Sibbald.
+*/
+/*
* Bacula Director -- next_vol -- handles finding the next
* volume for append. Split out of catreq.c August MMIII
* catalog request from the Storage daemon.
-
- * Kern Sibbald, March MMI
*
- * Version $Id$
+ * Kern Sibbald, March MMI
*/
+
+#include "bacula.h"
+#include "dird.h"
+
+static int const dbglvl = 50; /* debug level */
+
/*
- Copyright (C) 2001-2004 Kern Sibbald and John Walker
+ * We setup the StorageId or StorageId group if it is
+ * an autochanger from the Storage and put it in
+ * the media record.
+ * store == NULL => use existing StorageId
+ */
+void set_storageid_in_mr(STORE *store, MEDIA_DBR *mr)
+{
+ if (store == NULL) {
+ /* Just use the plain (single) StorageId */
+ mr->sid_group = edit_int64(mr->StorageId, mr->sid);
+ return;
+ }
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
+ /* At this point we know store != NULL */
+ mr->StorageId = store->StorageId;
+ /* Get to the parent of the autochanger (if any) */
+ if (store->changer) {
+ store = store->changer;
+ mr->StorageId = store->StorageId;
+ }
+ /* Go to the master shared storage head (if any) */
+ if (store->shared_storage && store->shared_storage->ac_group) {
+ store = store->shared_storage;
+ }
+ /* If it is an autochanger we should have an ac_group */
+ if (store->autochanger && store->ac_group) {
+ /* Note we keep the StorageId of the local autochanger */
+ mr->sid_group = store->ac_group;
+ } else {
+ /* Otherwise, we just use the plain (single) StorageId */
+ mr->sid_group = edit_int64(mr->StorageId, mr->sid);
+ }
+}
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- General Public License for more details.
+static void add_volume_to_exclude_list(JCR *jcr, int index, MEDIA_DBR *mr)
+{
+ char ed1[50];
+ if (index == 1) {
+ *jcr->next_vol_list = 0;
- You should have received a copy of the GNU General Public
- License along with this program; if not, write to the Free
- Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
- MA 02111-1307, USA.
+ } else if (*jcr->next_vol_list) {
+ pm_strcat(jcr->next_vol_list, ",");
+ }
+ pm_strcat(jcr->next_vol_list, edit_int64(mr->MediaId, ed1));
- */
+ /* The list is valid only in find_next_volume_for_append() */
+ mr->exclude_list = NULL;
+}
-#include "bacula.h"
-#include "dird.h"
+static void set_volume_to_exclude_list(JCR *jcr, int index, MEDIA_DBR *mr)
+{
+ if (index == 1) {
+ *jcr->next_vol_list = 0;
+ }
+ mr->exclude_list = jcr->next_vol_list;
+}
/*
* Items needed:
- * jcr->PoolId
- * jcr->store
+ * mr.PoolId must be set
+ * mr.ScratchPoolId could be set (used if create==true)
+ * jcr->wstore
* jcr->db
* jcr->pool
- * MEDIA_DBR mr (zeroed out)
+ * MEDIA_DBR mr with PoolId set
* create -- whether or not to create a new volume
*/
-int find_next_volume_for_append(JCR *jcr, MEDIA_DBR *mr, bool create)
+int find_next_volume_for_append(JCR *jcr, MEDIA_DBR *mr, int index,
+ bool create, bool prune)
{
int retry = 0;
bool ok;
bool InChanger;
- STORE *store = jcr->store;
+ STORE *store = jcr->wstore;
- mr->PoolId = jcr->PoolId;
bstrncpy(mr->MediaType, store->media_type, sizeof(mr->MediaType));
- Dmsg2(120, "CatReq FindMedia: Id=%d, MediaType=%s\n", mr->PoolId, mr->MediaType);
+ Dmsg6(dbglvl, "find_next_vol_for_append: JobId=%u PoolId=%d, MediaType=%s index=%d create=%d prune=%d\n",
+ (uint32_t)jcr->JobId, (int)mr->PoolId, mr->MediaType, index,
+ create, prune);
/*
* If we are using an Autochanger, restrict Volume
- * search to the Autochanger on the first pass
+ * search to the Autochanger on the first pass
*/
- InChanger = store->autochanger;
+ InChanger = (store->autochanger)? true : false;
+
+ /* Make sure we don't send two times the same volume in the same session */
+ set_volume_to_exclude_list(jcr, index, mr);
+
/*
* Find the Next Volume for Append
*/
/*
* 1. Look for volume with "Append" status.
*/
- ok = db_find_next_volume(jcr, jcr->db, 1, InChanger, mr);
- Dmsg2(100, "catreq after find_next_vol ok=%d FW=%d\n", ok, mr->FirstWritten);
+ set_storageid_in_mr(store, mr); /* put StorageId in new record */
+ ok = db_find_next_volume(jcr, jcr->db, index, InChanger, mr);
+
if (!ok) {
- /*
- * 2. Try finding a recycled volume
- */
- ok = find_recycled_volume(jcr, InChanger, mr);
- Dmsg2(100, "find_recycled_volume %d FW=%d\n", ok, mr->FirstWritten);
- if (!ok) {
- /*
- * 3. Try recycling any purged volume
- */
- ok = recycle_oldest_purged_volume(jcr, InChanger, mr);
- if (!ok) {
- /*
- * 4. Try pruning Volumes
- */
- prune_volumes(jcr);
- ok = recycle_oldest_purged_volume(jcr, InChanger, mr);
- if (InChanger) {
- InChanger = false;
- if (!ok) {
- continue; /* retry again accepting any volume */
- }
- }
- Dmsg2(200, "find_recycled_volume2 %d FW=%d\n", ok, mr->FirstWritten);
- if (!ok && create) {
- /*
- * 5. Try "creating" a new Volume
- */
- ok = newVolume(jcr, mr);
- }
- }
- }
-
- /*
- * Look at more drastic ways to find an Appendable Volume
- */
- if (!ok && (jcr->pool->purge_oldest_volume ||
- jcr->pool->recycle_oldest_volume)) {
- Dmsg2(200, "No next volume found. PurgeOldest=%d\n RecyleOldest=%d",
- jcr->pool->purge_oldest_volume, jcr->pool->recycle_oldest_volume);
- /* Find oldest volume to recycle */
- ok = db_find_next_volume(jcr, jcr->db, -1, InChanger, mr);
- Dmsg1(400, "Find oldest=%d\n", ok);
- if (ok) {
- UAContext *ua;
- Dmsg0(400, "Try purge.\n");
- /*
- * 5. Try to purging oldest volume only if not UA calling us.
- */
- ua = new_ua_context(jcr);
- if (jcr->pool->purge_oldest_volume && create) {
- Jmsg(jcr, M_INFO, 0, _("Purging oldest volume \"%s\"\n"), mr->VolumeName);
- ok = purge_jobs_from_volume(ua, mr);
- /*
- * 5. or try recycling the oldest volume
- */
- } else if (jcr->pool->recycle_oldest_volume) {
- Jmsg(jcr, M_INFO, 0, _("Pruning oldest volume \"%s\"\n"), mr->VolumeName);
- ok = prune_volume(ua, mr);
- }
- free_ua_context(ua);
- if (ok) {
- ok = recycle_volume(jcr, mr);
- Dmsg1(400, "Recycle after purge oldest=%d\n", ok);
- }
- }
- }
+ /*
+ * No volume found, apply algorithm
+ */
+ Dmsg4(dbglvl, "after find_next_vol ok=%d index=%d InChanger=%d Vstat=%s\n",
+ ok, index, InChanger, mr->VolStatus);
+ /*
+ * 2. Try finding a recycled volume
+ */
+ ok = find_recycled_volume(jcr, InChanger, mr, store);
+ set_storageid_in_mr(store, mr); /* put StorageId in new record */
+ Dmsg2(dbglvl, "find_recycled_volume ok=%d FW=%d\n", ok, mr->FirstWritten);
+ if (!ok) {
+ /*
+ * 3. Try recycling any purged volume
+ */
+ ok = recycle_oldest_purged_volume(jcr, InChanger, mr, store);
+ set_storageid_in_mr(store, mr); /* put StorageId in new record */
+ if (!ok) {
+ /*
+ * 4. Try pruning Volumes
+ */
+ if (prune) {
+ Dmsg0(dbglvl, "Call prune_volumes\n");
+ prune_volumes(jcr, InChanger, mr, store);
+ }
+ ok = recycle_oldest_purged_volume(jcr, InChanger, mr, store);
+ set_storageid_in_mr(store, mr); /* put StorageId in new record */
+ if (!ok && create) {
+ Dmsg4(dbglvl, "after prune volumes_vol ok=%d index=%d InChanger=%d Vstat=%s\n",
+ ok, index, InChanger, mr->VolStatus);
+ /*
+ * 5. Try pulling a volume from the Scratch pool
+ */
+ ok = get_scratch_volume(jcr, InChanger, mr, store);
+ set_storageid_in_mr(store, mr); /* put StorageId in new record */
+ Dmsg4(dbglvl, "after get scratch volume ok=%d index=%d InChanger=%d Vstat=%s\n",
+ ok, index, InChanger, mr->VolStatus);
+ }
+ /*
+ * If we are using an Autochanger and have not found
+ * a volume, retry looking for any volume.
+ */
+ if (!ok && InChanger) {
+ InChanger = false;
+ continue; /* retry again accepting any volume */
+ }
+ }
+ }
+
+
+ if (!ok && create) {
+ /*
+ * 6. Try "creating" a new Volume
+ */
+ ok = newVolume(jcr, mr, store);
+ }
+ /*
+ * Look at more drastic ways to find an Appendable Volume
+ */
+ if (!ok && (jcr->pool->purge_oldest_volume ||
+ jcr->pool->recycle_oldest_volume)) {
+ Dmsg2(dbglvl, "No next volume found. PurgeOldest=%d\n RecyleOldest=%d",
+ jcr->pool->purge_oldest_volume, jcr->pool->recycle_oldest_volume);
+ /* Find oldest volume to recycle */
+ set_storageid_in_mr(store, mr); /* update storage id */
+ ok = db_find_next_volume(jcr, jcr->db, -1, InChanger, mr);
+ set_storageid_in_mr(store, mr); /* update storageid */
+ Dmsg1(dbglvl, "Find oldest=%d Volume\n", ok);
+ if (ok && prune) {
+ UAContext *ua;
+ Dmsg0(dbglvl, "Try purge Volume.\n");
+ /*
+ * 7. Try to purging oldest volume only if not UA calling us.
+ */
+ ua = new_ua_context(jcr);
+ if (jcr->pool->purge_oldest_volume && create) {
+ Jmsg(jcr, M_INFO, 0, _("Purging oldest volume \"%s\"\n"), mr->VolumeName);
+ ok = purge_jobs_from_volume(ua, mr);
+ /*
+ * 8. or try recycling the oldest volume
+ */
+ } else if (jcr->pool->recycle_oldest_volume) {
+ Jmsg(jcr, M_INFO, 0, _("Pruning oldest volume \"%s\"\n"), mr->VolumeName);
+ ok = prune_volume(ua, mr);
+ }
+ free_ua_context(ua);
+ if (ok) {
+ ok = recycle_volume(jcr, mr);
+ Dmsg1(dbglvl, "Recycle after purge oldest=%d\n", ok);
+ }
+ }
+ }
}
- Dmsg2(100, "VolJobs=%d FirstWritten=%d\n", mr->VolJobs, mr->FirstWritten);
+ Dmsg2(dbglvl, "VolJobs=%d FirstWritten=%d\n", mr->VolJobs, mr->FirstWritten);
if (ok) {
- /* If we can use the volume, check if it is expired */
- if (has_volume_expired(jcr, mr)) {
- if (retry++ < 200) { /* sanity check */
- continue; /* try again from the top */
- } else {
- Jmsg(jcr, M_ERROR, 0, _(
+ /* If we can use the volume, check if it is expired */
+ if (has_volume_expired(jcr, mr)) {
+ if (retry++ < 200) { /* sanity check */
+ continue; /* try again from the top */
+ } else {
+ Jmsg(jcr, M_ERROR, 0, _(
"We seem to be looping trying to find the next volume. I give up.\n"));
- }
- }
+ }
+ }
}
break;
} /* end for loop */
db_unlock(jcr->db);
+ Dmsg1(dbglvl, "return ok=%d find_next_vol\n", ok);
+
+ /* We keep the record of all previous volumes requested */
+ if (ok) {
+ add_volume_to_exclude_list(jcr, index, mr);;
+ }
return ok;
}
bool has_volume_expired(JCR *jcr, MEDIA_DBR *mr)
{
bool expired = false;
+ char ed1[50];
/*
* Check limits and expirations if "Append" and it has been used
* i.e. mr->VolJobs > 0
if (strcmp(mr->VolStatus, "Append") == 0 && mr->VolJobs > 0) {
/* First handle Max Volume Bytes */
if ((mr->MaxVolBytes > 0 && mr->VolBytes >= mr->MaxVolBytes)) {
- Jmsg(jcr, M_INFO, 0, _("Max Volume bytes exceeded. "
- "Marking Volume \"%s\" as Full.\n"), mr->VolumeName);
- bstrncpy(mr->VolStatus, "Full", sizeof(mr->VolStatus));
- expired = true;
+ Jmsg(jcr, M_INFO, 0, _("Max Volume bytes=%s exceeded. "
+ "Marking Volume \"%s\" as Full.\n"),
+ edit_uint64_with_commas(mr->MaxVolBytes, ed1), mr->VolumeName);
+ bstrncpy(mr->VolStatus, "Full", sizeof(mr->VolStatus));
+ expired = true;
/* Now see if Volume should only be used once */
} else if (mr->VolBytes > 0 && jcr->pool->use_volume_once) {
- Jmsg(jcr, M_INFO, 0, _("Volume used once. "
- "Marking Volume \"%s\" as Used.\n"), mr->VolumeName);
- bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
- expired = true;
+ Jmsg(jcr, M_INFO, 0, _("Volume used once. "
+ "Marking Volume \"%s\" as Used.\n"), mr->VolumeName);
+ bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
+ expired = true;
/* Now see if Max Jobs written to volume */
} else if (mr->MaxVolJobs > 0 && mr->MaxVolJobs <= mr->VolJobs) {
- Jmsg(jcr, M_INFO, 0, _("Max Volume jobs exceeded. "
- "Marking Volume \"%s\" as Used.\n"), mr->VolumeName);
- bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
- expired = true;
+ Jmsg(jcr, M_INFO, 0, _("Max Volume jobs=%s exceeded. "
+ "Marking Volume \"%s\" as Used.\n"),
+ edit_uint64_with_commas(mr->MaxVolJobs, ed1), mr->VolumeName);
+ Dmsg3(dbglvl, "MaxVolJobs=%d JobId=%d Vol=%s\n", mr->MaxVolJobs,
+ (uint32_t)jcr->JobId, mr->VolumeName);
+ bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
+ expired = true;
/* Now see if Max Files written to volume */
} else if (mr->MaxVolFiles > 0 && mr->MaxVolFiles <= mr->VolFiles) {
- Jmsg(jcr, M_INFO, 0, _("Max Volume files exceeded. "
- "Marking Volume \"%s\" as Used.\n"), mr->VolumeName);
- bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
- expired = true;
+ Jmsg(jcr, M_INFO, 0, _("Max Volume files=%s exceeded. "
+ "Marking Volume \"%s\" as Used.\n"),
+ edit_uint64_with_commas(mr->MaxVolFiles, ed1), mr->VolumeName);
+ bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
+ expired = true;
/* Finally, check Use duration expiration */
} else if (mr->VolUseDuration > 0) {
- utime_t now = time(NULL);
- /* See if Vol Use has expired */
- if (mr->VolUseDuration <= (now - mr->FirstWritten)) {
- Jmsg(jcr, M_INFO, 0, _("Max configured use duration exceeded. "
- "Marking Volume \"%s\" as Used.\n"), mr->VolumeName);
- bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
- expired = true;
- }
+ utime_t now = time(NULL);
+ /* See if Vol Use has expired */
+ if (mr->VolUseDuration <= (now - mr->FirstWritten)) {
+ Jmsg(jcr, M_INFO, 0, _("Max configured use duration=%s sec. exceeded. "
+ "Marking Volume \"%s\" as Used.\n"),
+ edit_uint64_with_commas(mr->VolUseDuration, ed1), mr->VolumeName);
+ bstrncpy(mr->VolStatus, "Used", sizeof(mr->VolStatus));
+ expired = true;
+ }
}
}
if (expired) {
/* Need to update media */
+ Dmsg1(dbglvl, "Vol=%s has expired update media record\n", mr->VolumeName);
+ set_storageid_in_mr(NULL, mr);
if (!db_update_media_record(jcr, jcr->db, mr)) {
- Jmsg(jcr, M_ERROR, 0, _("Catalog error updating volume \"%s\". ERR=%s"),
- mr->VolumeName, db_strerror(jcr->db));
+ Jmsg(jcr, M_ERROR, 0, _("Catalog error updating volume \"%s\". ERR=%s"),
+ mr->VolumeName, db_strerror(jcr->db));
}
}
+ Dmsg2(dbglvl, "Vol=%s expired=%d\n", mr->VolumeName, expired);
return expired;
}
* Try hard to recycle the current volume
*
* Returns: on failure - reason = NULL
- * on success - reason - pointer to reason
+ * on success - reason - pointer to reason
*/
void check_if_volume_valid_or_recyclable(JCR *jcr, MEDIA_DBR *mr, const char **reason)
{
/* Check if a duration or limit has expired */
if (has_volume_expired(jcr, mr)) {
- *reason = "volume has expired";
+ *reason = _("volume has expired");
+ if (!mr->Recycle) { /* cannot recycle */
+ return;
+ }
/* Keep going because we may be able to recycle volume */
}
*/
if (strcmp(mr->VolStatus, "Purged") == 0) {
if (recycle_volume(jcr, mr)) {
- Jmsg(jcr, M_INFO, 0, "Recycled current volume \"%s\"\n", mr->VolumeName);
- *reason = NULL;
- return;
+ Jmsg(jcr, M_INFO, 0, _("Recycled current volume \"%s\"\n"), mr->VolumeName);
+ *reason = NULL;
+ return;
} else {
- /* In principle this shouldn't happen */
- *reason = "and recycling of current volume failed";
- return;
+ /* In principle this shouldn't happen */
+ *reason = _("and recycling of current volume failed");
+ return;
}
}
/* At this point, the volume is not valid for writing */
- *reason = "but should be Append, Purged or Recycle";
+ *reason = _("but should be Append, Purged or Recycle");
/*
* What we're trying to do here is see if the current volume is
* it now possible to reuse it for the job that it is currently
* needed for?
*/
- if ((mr->LastWritten + mr->VolRetention) < (utime_t)time(NULL)
- && mr->Recycle && jcr->pool->recycle_current_volume
- && (strcmp(mr->VolStatus, "Full") == 0 ||
- strcmp(mr->VolStatus, "Used") == 0)) {
+ if (!mr->Recycle) {
+ *reason = _("volume has recycling disabled");
+ return;
+ }
+ /*
+ * Check retention period from last written, but recycle to within
+ * a minute to try to catch close calls ...
+ */
+ if ((mr->LastWritten + mr->VolRetention - 60) < (utime_t)time(NULL)
+ && jcr->pool->recycle_current_volume
+ && (strcmp(mr->VolStatus, "Full") == 0 ||
+ strcmp(mr->VolStatus, "Used") == 0)) {
/*
* Attempt prune of current volume to see if we can
* recycle it for use.
free_ua_context(ua);
if (ok) {
- /* If fully purged, recycle current volume */
- if (recycle_volume(jcr, mr)) {
- Jmsg(jcr, M_INFO, 0, "Recycled current volume \"%s\"\n", mr->VolumeName);
- *reason = NULL;
- } else {
- *reason = "but should be Append, Purged or Recycle (recycling of the "
- "current volume failed)";
- }
+ /* If fully purged, recycle current volume */
+ if (recycle_volume(jcr, mr)) {
+ Jmsg(jcr, M_INFO, 0, _("Recycled current volume \"%s\"\n"), mr->VolumeName);
+ *reason = NULL;
+ } else {
+ *reason = _("but should be Append, Purged or Recycle (recycling of the "
+ "current volume failed)");
+ }
} else {
- *reason = "but should be Append, Purged or Recycle (cannot automatically "
- "recycle current volume, as it still contains unpruned data)";
+ *reason = _("but should be Append, Purged or Recycle (cannot automatically "
+ "recycle current volume, as it still contains unpruned data "
+ "or the Volume Retention time has not expired.)");
}
}
}
+
+static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
+
+bool get_scratch_volume(JCR *jcr, bool InChanger, MEDIA_DBR *mr,
+ STORE *store)
+{
+ MEDIA_DBR smr; /* for searching scratch pool */
+ POOL_DBR spr, pr;
+ bool ok = false;
+ bool found = false;
+
+ /* Only one thread at a time can pull from the scratch pool */
+ P(mutex);
+ /*
+ * Get Pool record for Scratch Pool
+ * choose between ScratchPoolId and Scratch
+ * db_get_pool_numvols will first try ScratchPoolId,
+ * and then try the pool named Scratch
+ */
+ memset(&spr, 0, sizeof(spr));
+ bstrncpy(spr.Name, "Scratch", sizeof(spr.Name));
+ spr.PoolId = mr->ScratchPoolId;
+ if (db_get_pool_record(jcr, jcr->db, &spr)) {
+ smr.PoolId = spr.PoolId;
+ bstrncpy(smr.VolStatus, "Append", sizeof(smr.VolStatus)); /* want only appendable volumes */
+ bstrncpy(smr.MediaType, mr->MediaType, sizeof(smr.MediaType));
+
+ /*
+ * If we do not find a valid Scratch volume, try
+ * recycling any existing purged volumes, then
+ * try to take the oldest volume.
+ */
+ set_storageid_in_mr(store, &smr); /* put StorageId in new record */
+ if (db_find_next_volume(jcr, jcr->db, 1, InChanger, &smr)) {
+ found = true;
+
+ } else if (find_recycled_volume(jcr, InChanger, &smr, store)) {
+ found = true;
+
+ } else if (recycle_oldest_purged_volume(jcr, InChanger, &smr, store)) {
+ found = true;
+ }
+
+ if (found) {
+ POOL_MEM query(PM_MESSAGE);
+
+ /*
+ * Get pool record where the Scratch Volume will go to ensure
+ * that we can add a Volume.
+ */
+ memset(&pr, 0, sizeof(pr));
+ bstrncpy(pr.Name, jcr->pool->name(), sizeof(pr.Name));
+
+ if (!db_get_pool_numvols(jcr, jcr->db, &pr)) {
+ Jmsg(jcr, M_WARNING, 0, _("Unable to get Pool record: ERR=%s"),
+ db_strerror(jcr->db));
+ goto bail_out;
+ }
+
+ /* Make sure there is room for another volume */
+ if (pr.MaxVols > 0 && pr.NumVols >= pr.MaxVols) {
+ Jmsg(jcr, M_WARNING, 0, _("Unable add Scratch Volume, Pool \"%s\" full MaxVols=%d\n"),
+ jcr->pool->name(), pr.MaxVols);
+ goto bail_out;
+ }
+
+ mr->copy(&smr);
+ set_storageid_in_mr(store, mr);
+
+ /* Set default parameters from current pool */
+ set_pool_dbr_defaults_in_media_dbr(mr, &pr);
+
+ /*
+ * set_pool_dbr_defaults_in_media_dbr set VolStatus to Append,
+ * we could have Recycled media, also, we retain the old
+ * RecyclePoolId.
+ */
+ bstrncpy(mr->VolStatus, smr.VolStatus, sizeof(smr.VolStatus));
+ mr->RecyclePoolId = smr.RecyclePoolId;
+
+ if (!db_update_media_record(jcr, jcr->db, mr)) {
+ Jmsg(jcr, M_WARNING, 0, _("Failed to move Scratch Volume. ERR=%s\n"),
+ db_strerror(jcr->db));
+ goto bail_out;
+ }
+
+ Jmsg(jcr, M_INFO, 0, _("Using Volume \"%s\" from '%s' %spool.\n"),
+ mr->VolumeName, spr.Name,
+ ((strcmp(spr.Name, "Scratch") == 0) ? "" : "Scratch "));
+
+ ok = true;
+ }
+ }
+bail_out:
+ V(mutex);
+ return ok;
+}
projects / bacula / bacula / blobdiff