1 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
\r
2 "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
\r
3 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
\r
5 <link rel="icon" type="image/x-icon" href="/favicon.ico">
\r
6 <meta http-equiv="Content-Type" content="application/xhtml+xml; charset=UTF-8" />
\r
7 <meta name="generator" content="AsciiDoc 8.6.8" />
\r
8 <title>i3: i3 testsuite</title>
\r
9 <link rel="stylesheet" href="/css/style.css" type="text/css" />
\r
10 <link rel="stylesheet" href="/css/xhtml11.css" type="text/css" />
\r
11 <script type="text/javascript">
\r
13 document.addEventListener("DOMContentLoaded", function(){asciidoc.footnotes(); asciidoc.toc(2);}, false);
\r
16 <script type="text/javascript" src="/js/asciidoc-xhtml11.js"></script>
\r
18 <body class="article">
\r
21 <a href="/"><h1 id="title">i3 - improved tiling WM</h1></a>
\r
23 <li><a style="border-bottom: 2px solid #fff" href="/docs">Docs</a></li>
\r
24 <li><a href="/screenshots">Screens</a></li>
\r
25 <li><a href="https://faq.i3wm.org/">FAQ</a></li>
\r
26 <li><a href="/contact">Contact</a></li>
\r
27 <li><a href="https://github.com/i3/i3/issues">Bugs</a></li>
\r
29 <br style="clear: both">
\r
32 <h1>i3 testsuite</h1>
\r
33 <span id="author">Michael Stapelberg</span><br />
\r
34 <span id="email"><tt><<a href="mailto:michael@i3wm.org">michael@i3wm.org</a>></tt></span><br />
\r
35 <span id="revdate">September 2012</span>
\r
37 <div id="toctitle">Table of Contents</div>
38 <noscript><p><b>JavaScript must be enabled in your browser to display the table of contents.</b></p></noscript>
42 <div class="sectionbody">
\r
43 <div class="paragraph"><p>This document explains how the i3 testsuite works, how to use it and extend it.
\r
44 It is targeted at developers who not necessarily have been doing testing before
\r
45 or have not been testing in Perl before. In general, the testsuite is not of
\r
46 interest for end users.</p></div>
\r
50 <h2 id="_introduction">1. Introduction</h2>
\r
51 <div class="sectionbody">
\r
52 <div class="paragraph"><p>The i3 testsuite is a collection of files which contain testcases for various
\r
53 i3 features. Some of them test if a certain workflow works correctly (moving
\r
54 windows, focus behaviour, …). Others are regression tests and contain code
\r
55 which previously made i3 crash or lead to unexpected behaviour. They then check
\r
56 if i3 still runs (meaning it did not crash) and if it handled everything
\r
57 correctly.</p></div>
\r
58 <div class="paragraph"><p>The goal of having these tests is to automatically find problems and to
\r
59 automatically get a feel for whether a change in the source code breaks any
\r
60 existing feature. After every modification of the i3 sourcecode, the developer
\r
61 should run the full testsuite. If one of the tests fails, the corresponding
\r
62 problem should be fixed (or, in some cases, the testcase has to be modified).
\r
63 For every bugreport, a testcase should be written to test the correct
\r
64 behaviour. Initially, it will fail, but after fixing the bug, it will pass.
\r
65 This ensures (or increases the chance) that bugs which have been fixed once
\r
66 will never be found again.</p></div>
\r
67 <div class="paragraph"><p>Also, when implementing a new feature, a testcase might be a good way to be
\r
68 able to easily test if the feature is working correctly. Many developers will
\r
69 test manually if everything works. Having a testcase not only helps you with
\r
70 that, but it will also be useful for every future change.</p></div>
\r
74 <h2 id="_relevant_documentation">2. Relevant documentation</h2>
\r
75 <div class="sectionbody">
\r
76 <div class="paragraph"><p>Apart from this document, you should also have a look at:</p></div>
\r
77 <div class="olist arabic"><ol class="arabic">
\r
80 The "Modern Perl" book, which can be found at
\r
81 <a href="http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf">http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf</a>
\r
86 The latest Perl documentation of the "i3test" (general testcase setup) and
\r
87 "i3test::Test" (additional test instructions) modules:
\r
88 <a href="http://build.i3wm.org/docs/lib-i3test.html">http://build.i3wm.org/docs/lib-i3test.html</a> respectively
\r
89 <a href="http://build.i3wm.org/docs/lib-i3test-test.html">http://build.i3wm.org/docs/lib-i3test-test.html</a>
\r
94 The latest documentation on i3’s IPC interface:
\r
95 <a href="http://build.i3wm.org/docs/ipc.html">http://build.i3wm.org/docs/ipc.html</a>
\r
101 <div class="sect1">
\r
102 <h2 id="_implementation">3. Implementation</h2>
\r
103 <div class="sectionbody">
\r
104 <div class="paragraph"><p>For several reasons, the i3 testsuite has been implemented in Perl:</p></div>
\r
105 <div class="olist arabic"><ol class="arabic">
\r
108 Perl has a long tradition of testing. Every popular/bigger Perl module which
\r
109 you can find on CPAN will not only come with documentation, but also with
\r
110 tests. Therefore, the available infrastructure for tests is comprehensive.
\r
111 See for example the excellent <a href="http://search.cpan.org/perldoc?Test::More">http://search.cpan.org/perldoc?Test::More</a>
\r
112 and the referenced <a href="http://search.cpan.org/perldoc?Test::Tutorial">http://search.cpan.org/perldoc?Test::Tutorial</a>.
\r
117 Perl is widely available and has a well-working package infrastructure.
\r
122 The author is familiar with Perl :).
\r
127 It is a good idea to use a different language for the tests than the
\r
128 implementation itself.
\r
132 <div class="paragraph"><p>Please do not start programming language flamewars at this point.</p></div>
\r
133 <div class="sect2">
\r
134 <h3 id="_installing_the_dependencies">3.1. Installing the dependencies</h3>
\r
135 <div class="paragraph"><p>As usual with Perl programs, the testsuite ships with a <tt>Makefile.PL</tt>.
\r
136 This file specifies which Perl modules the testsuite depends on and can be used
\r
137 to install all of them.</p></div>
\r
138 <div class="paragraph"><p>Perl modules are distributed via CPAN, and there is the official, standard CPAN
\r
139 client, simply called <tt>cpan</tt>. It comes with every Perl installation and can be
\r
140 used to install the testsuite. Many users prefer to use the more modern
\r
141 <tt>cpanminus</tt> instead, though (because it asks no questions and just works):</p></div>
\r
142 <div class="paragraph"><p>The tests additionally require <tt>Xephyr(1)</tt> to run a nested X server. Install
\r
143 <tt>xserver-xephyr</tt> on Debian or <tt>xorg-xserver-xephyr</tt> on Arch Linux.</p></div>
\r
144 <div class="listingblock">
\r
145 <div class="title">Installing testsuite dependencies using cpanminus (preferred)</div>
\r
146 <div class="content">
\r
147 <pre><tt>$ cd ~/i3/testcases
\r
148 $ sudo apt-get install cpanminus
\r
149 $ sudo cpanm .</tt></pre>
\r
151 <div class="paragraph"><p>If you don’t want to use cpanminus for some reason, the same works with cpan:</p></div>
\r
152 <div class="listingblock">
\r
153 <div class="title">Installing testsuite dependencies using cpan</div>
\r
154 <div class="content">
\r
155 <pre><tt>$ cd ~/i3/testcases
\r
156 $ sudo cpan .</tt></pre>
\r
158 <div class="paragraph"><p>In case you don’t have root permissions, you can also install into your home
\r
159 directory, see <a href="http://michael.stapelberg.de/cpan/">http://michael.stapelberg.de/cpan/</a></p></div>
\r
161 <div class="sect2">
\r
162 <h3 id="_mechanisms">3.2. Mechanisms</h3>
\r
163 <div class="sect3">
\r
164 <h4 id="_script_complete_run">3.2.1. Script: complete-run</h4>
\r
165 <div class="paragraph"><p>The testcases are run by a script called <tt>complete-run.pl</tt>. It runs all
\r
166 testcases by default, but you can be more specific and let it only run one or
\r
167 more testcases. Also, it takes care of starting up a separate instance of i3
\r
168 with an appropriate configuration file and creates a folder for each run
\r
169 containing the appropriate i3 logfile for each testcase. The latest folder can
\r
170 always be found under the symlink <tt>latest/</tt>. Unless told differently, it will
\r
171 run the tests on a separate X server instance (using Xephyr).</p></div>
\r
172 <div class="paragraph"><p>Xephyr will open a window where you can inspect the running test. You can run
\r
173 the tests without an X session with Xvfb, such as with <tt>xvfb-run
\r
174 ./complete-run</tt>. This will also speed up the tests signficantly especially on
\r
175 machines without a powerful video card.</p></div>
\r
176 <div class="listingblock">
\r
177 <div class="title">Example invocation of complete-run.pl+</div>
\r
178 <div class="content">
\r
179 <pre><tt>$ cd ~/i3/testcases
\r
181 $ ./complete-run.pl
\r
182 # output omitted because it is very long
\r
183 All tests successful.
\r
184 Files=78, Tests=734, 27 wallclock secs ( 0.38 usr 0.48 sys + 17.65 cusr 3.21 csys = 21.72 CPU)
\r
187 $ ./complete-run.pl t/04-floating.t
\r
188 [:3] i3 startup: took 0.07s, status = 1
\r
189 [:3] Running t/04-floating.t with logfile testsuite-2011-09-24-16-06-04-4.0.2-226-g1eb011a/i3-log-for-04-floating.t
\r
190 [:3] t/04-floating.t finished
\r
192 output for t/04-floating.t:
\r
193 ok 1 - use X11::XCB::Window;
\r
194 ok 2 - The object isa X11::XCB::Window
\r
195 ok 3 - Window is mapped
\r
196 ok 4 - i3 raised the width to 75
\r
197 ok 5 - i3 raised the height to 50
\r
198 ok 6 - i3 did not map it to (0x0)
\r
199 ok 7 - The object isa X11::XCB::Window
\r
200 ok 8 - i3 let the width at 80
\r
201 ok 9 - i3 let the height at 90
\r
202 ok 10 - i3 mapped it to x=1
\r
203 ok 11 - i3 mapped it to y=18
\r
204 ok 12 - The object isa X11::XCB::Window
\r
205 ok 13 - i3 let the width at 80
\r
206 ok 14 - i3 let the height at 90
\r
209 All tests successful.
\r
210 Files=1, Tests=14, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.19 cusr 0.03 csys = 0.23 CPU)
\r
213 $ less latest/i3-log-for-04-floating.t</tt></pre>
\r
215 <div class="paragraph"><p>If your attempt to run the tests with a bare call to ./complete-run.pl fails, try this:</p></div>
\r
216 <div class="listingblock">
\r
217 <div class="content">
\r
218 <pre><tt>$ ./complete-run.pl --parallel=1 --keep-xserver-output</tt></pre>
\r
220 <div class="paragraph"><p>This will show the output of Xephyr, which is the X server implementation we
\r
221 use for testing.</p></div>
\r
223 <div class="sect3">
\r
224 <h4 id="_ipc_interface">3.2.2. IPC interface</h4>
\r
225 <div class="paragraph"><p>The testsuite makes extensive use of the IPC (Inter-Process Communication)
\r
226 interface which i3 provides. It is used for the startup process of i3, for
\r
227 terminating it cleanly and (most importantly) for modifying and getting the
\r
228 current state (layout tree).</p></div>
\r
229 <div class="paragraph"><p>See [<a href="http://i3wm.org/docs/ipc.html">http://i3wm.org/docs/ipc.html</a>] for documentation on the IPC interface.</p></div>
\r
231 <div class="sect3">
\r
232 <h4 id="_x11_xcb">3.2.3. X11::XCB</h4>
\r
233 <div class="paragraph"><p>In order to open new windows, change attributes, get events, etc., the
\r
234 testsuite uses X11::XCB, a new (and quite specific to i3 at the moment) Perl
\r
235 module which uses the XCB protocol description to generate Perl bindings to
\r
236 X11. They work in a very similar way to libxcb (which i3 uses) and provide
\r
237 relatively high-level interfaces (objects such as <tt>X11::XCB::Window</tt>) aswell as
\r
238 access to the low-level interface, which is very useful when testing a window
\r
242 <div class="sect2">
\r
243 <h3 id="_filesystem_structure">3.3. Filesystem structure</h3>
\r
244 <div class="paragraph"><p>In the git root of i3, the testcases live in the folder <tt>testcases</tt>. This
\r
245 folder contains the <tt>complete-run.pl</tt> and a base configuration file which will
\r
246 be used for the tests. The different testcases (their file extension is .t, not
\r
247 .pl) themselves can be found in the conventionally named subfolder <tt>t</tt>:</p></div>
\r
248 <div class="listingblock">
\r
249 <div class="title">Filesystem structure</div>
\r
250 <div class="content">
\r
251 <pre><tt>├── testcases
\r
252 │ ├── complete-run.pl
\r
253 │ ├── i3-test.config
\r
256 │ │ ├── SocketActivation.pm
\r
257 │ │ └── StartXDummy.pm
\r
261 │ │ ├── 02-fullscreen.t
\r
263 │ │ ├── omitted for brevity
\r
265 │ │ └── 74-regress-focus-toggle.t</tt></pre>
\r
270 <div class="sect1">
\r
271 <h2 id="_anatomy_of_a_testcase">4. Anatomy of a testcase</h2>
\r
272 <div class="sectionbody">
\r
273 <div class="paragraph"><p>Learning by example is definitely a good strategy when you are wondering how to
\r
274 write a testcase. Let’s take <tt>t/11-goto.t</tt> as an easy example and go through it
\r
275 step by step:</p></div>
\r
276 <div class="listingblock">
\r
277 <div class="title">t/11-goto.t: Boilerplate</div>
\r
278 <div class="content">
\r
280 # vim:ts=4:sw=4:expandtab
\r
285 my $x = X11::XCB::Connection->new;</tt></pre>
\r
287 <div class="paragraph"><p>This is what we call boilerplate. It exists at the top of every test file (to
\r
288 some extent). The first line is the shebang, which specifies that this file is
\r
289 a Perl script. The second line contains VIM specific settings on how to
\r
290 edit/format this file (use spaces instead of tabs, indent using 4 spaces).
\r
291 Afterwards, the <tt>i3test</tt> module is used. This module contains i3 testsuite
\r
292 specific functions which you are strongly encouraged to use. They make writing
\r
293 testcases a lot easier and will make it easier for other people to read your
\r
295 <div class="paragraph"><p>The next line uses the <tt>File::Temp</tt> module. This is specific to this testcase,
\r
296 because it needs to generate a temporary name during the test. Many testcases
\r
297 use only the <tt>i3test</tt> module.</p></div>
\r
298 <div class="paragraph"><p>The last line opens a connection to X11. You might or might not need this in
\r
299 your testcase, depending on whether you are going to open windows (etc.) or
\r
300 only use i3 commands.</p></div>
\r
301 <div class="listingblock">
\r
302 <div class="title">t/11-goto.t: Setup</div>
\r
303 <div class="content">
\r
304 <pre><tt>my $tmp = fresh_workspace;
\r
306 cmd 'split h';</tt></pre>
\r
308 <div class="paragraph"><p>The first line calls i3test’s <tt>fresh_workspace</tt> function which looks for a
\r
309 currently unused workspace, switches to it, and returns its name. The variable
\r
310 <tt>$tmp</tt> will end up having a value such as <tt>"/tmp/87kBVcHbA9"</tt>. Note that this
\r
311 is not (necessarily) a valid path, it’s just a random workspace name.</p></div>
\r
312 <div class="paragraph"><p>So, now that we are on a new workspace, we ensure that the workspace uses
\r
313 horizontal orientation by issuing the <tt>split h</tt> command (see the i3 User’s
\r
314 Guide for a list of commands). This is not strictly necessary, but good style.
\r
315 In general, the <tt>cmd</tt> function executes the specified i3 command by using the
\r
316 IPC interface and returns once i3 acknowledged the command.</p></div>
\r
317 <div class="listingblock">
\r
318 <div class="title">t/11-goto.t: Setup</div>
\r
319 <div class="content">
\r
320 <pre><tt>#####################################################################
\r
321 # Create two windows and make sure focus switching works
\r
322 #####################################################################
\r
324 my $top = open_window($x);
\r
325 my $mid = open_window($x);
\r
326 my $bottom = open_window($x);</tt></pre>
\r
328 <div class="paragraph"><p>In every major section of a testcase, you should put a comment like the one
\r
329 above. This makes it immediately clear how the file is structured.</p></div>
\r
330 <div class="paragraph"><p>The <tt>open_window</tt> function opens a standard window, which will then be put into
\r
331 tiling mode by i3. If you want a floating window, use the
\r
332 <tt>open_floating_window</tt> function. These functions accept the same parameters as
\r
333 <tt>X11::XCB::Window→new</tt>, see the i3test documentation at TODO.</p></div>
\r
334 <div class="listingblock">
\r
335 <div class="title">t/11-goto.t: Helper function</div>
\r
336 <div class="content">
\r
338 # Returns the input focus after sending the given command to i3 via IPC
\r
339 # and syncing with i3
\r
346 return $x->input_focus;
\r
349 <div class="paragraph"><p>This section defines a helper function which will be used over and over in this
\r
350 testcase. If you have code which gets executed more than once or twice
\r
351 (depending on the length of your test, use your best judgement), please put it
\r
352 in a function. Tests should be short, concise and clear.</p></div>
\r
353 <div class="paragraph"><p>The <tt>focus_after</tt> function executes a command and returns the X11 focus after
\r
354 the command was executed. The <tt>sync_with_i3</tt> command makes sure that i3 could
\r
355 push its state to X11. See <a href="#i3_sync">[i3_sync]</a> to learn how this works exactly.</p></div>
\r
356 <div class="listingblock">
\r
357 <div class="title">t/11-goto.t: Test assumptions</div>
\r
358 <div class="content">
\r
359 <pre><tt>$focus = $x->input_focus;
\r
360 is($focus, $bottom->id, "Latest window focused");
\r
362 $focus = focus_after('focus left');
\r
363 is($focus, $mid->id, "Middle window focused");</tt></pre>
\r
365 <div class="paragraph"><p>Now, we run the first two real tests. They use <tt>Test::More</tt>'s <tt>is</tt> function,
\r
366 which compares two values and prints the differences if they are not the same.
\r
367 After the arguments, we supply a short comment to indicate what we are testing
\r
368 here. This makes it vastly more easy for the developer to spot which testcase
\r
369 is the problem in case one fails.</p></div>
\r
370 <div class="paragraph"><p>The first test checks that the most recently opened window is focused.
\r
371 Afterwards, the command <tt>focus left</tt> is issued and it is verified that the
\r
372 middle window now has focus.</p></div>
\r
373 <div class="paragraph"><p>Note that this is not a comprehensive test of the <tt>focus</tt> command — we would
\r
374 have to test wrapping, focus when using a more complex layout, focusing the
\r
375 parent/child containers, etc. But that is not the point of this testcase.
\r
376 Instead, we just want to know if <tt>$x→input_focus</tt> corresponds with what we are
\r
377 expecting. If not, something is completely wrong with the test environment and
\r
378 this trivial test will fail.</p></div>
\r
379 <div class="listingblock">
\r
380 <div class="title">t/11-goto.t: Test that the feature does not work (yet)</div>
\r
381 <div class="content">
\r
382 <pre><tt>#####################################################################
\r
383 # Now goto a mark which does not exist
\r
384 #####################################################################
\r
386 my $random_mark = mktemp('mark.XXXXXX');
\r
388 $focus = focus_after(qq|[con_mark="$random_mark"] focus|);
\r
389 is($focus, $mid->id, "focus unchanged");</tt></pre>
\r
391 <div class="paragraph"><p>Syntax hint: The qq keyword is the interpolating quote operator. It lets you
\r
392 chose a quote character (in this case the <tt>|</tt> character, a pipe). This makes
\r
393 having double quotes in our string easy.</p></div>
\r
394 <div class="paragraph"><p>In this new major section, a random mark (mark is an identifier for a window,
\r
395 see "VIM-like marks" in the i3 User’s Guide) will be generated. Afterwards, we
\r
396 test that trying to focus that mark will not do anything. This is important: Do
\r
397 not only test that using a feature has the expected outcome, but also test that
\r
398 using it without properly initializing it does no harm. This command could for
\r
399 example have changed focus anyways (a bug) or crash i3 (obviously a bug).</p></div>
\r
400 <div class="listingblock">
\r
401 <div class="title">t/11-goto.t: Test that the feature does work</div>
\r
402 <div class="content">
\r
403 <pre><tt>cmd "mark $random_mark";
\r
405 $focus = focus_after('focus left');
\r
406 is($focus, $top->id, "Top window focused");
\r
408 $focus = focus_after(qq|[con_mark="$random_mark"] focus|);
\r
409 is($focus, $mid->id, "goto worked");</tt></pre>
\r
411 <div class="paragraph"><p>Remember: Focus was on the middle window (we verified that earlier in "Test
\r
412 assumptions"). We now mark the middle window with our randomly generated mark.
\r
413 Afterwards, we switch focus away from the middle window to be able to tell if
\r
414 focusing it via its mark will work. If the test works, the goto command seems
\r
415 to be working.</p></div>
\r
416 <div class="listingblock">
\r
417 <div class="title">t/11-goto.t: Test corner case</div>
\r
418 <div class="content">
\r
419 <pre><tt># check that we can specify multiple criteria
\r
421 $focus = focus_after('focus left');
\r
422 is($focus, $top->id, "Top window focused");
\r
424 $focus = focus_after(qq|[con_mark="$random_mark" con_mark="$random_mark"] focus|);
\r
425 is($focus, $mid->id, "goto worked");</tt></pre>
\r
427 <div class="paragraph"><p>Now we test the same feature, but specifying the mark twice in the command.
\r
428 This should have no effect, but let’s be sure: test it and see if things go
\r
430 <div class="listingblock">
\r
431 <div class="title">t/11-goto.t: Test second code path</div>
\r
432 <div class="content">
\r
433 <pre><tt>#####################################################################
\r
434 # Check whether the focus command will switch to a different
\r
435 # workspace if necessary
\r
436 #####################################################################
\r
438 my $tmp2 = fresh_workspace;
\r
440 is(focused_ws(), $tmp2, 'tmp2 now focused');
\r
442 cmd qq|[con_mark="$random_mark"] focus|;
\r
444 is(focused_ws(), $tmp, 'tmp now focused');</tt></pre>
\r
446 <div class="paragraph"><p>This part of the test checks that focusing windows by mark works across
\r
447 workspaces. It uses i3test’s <tt>focused_ws</tt> function to get the current
\r
448 workspace.</p></div>
\r
449 <div class="listingblock">
\r
450 <div class="title">t/11-goto.t: Test second code path</div>
\r
451 <div class="content">
\r
452 <pre><tt>done_testing;</tt></pre>
\r
454 <div class="paragraph"><p>The end of every testcase has to contain the <tt>done_testing</tt> line. This tells
\r
455 <tt>complete-run.pl</tt> that the test was finished successfully. If it does not
\r
456 occur, the test might have crashed during execution — some of the reasons why
\r
457 that could happen are bugs in the used modules, bugs in the testcase itself or
\r
458 an i3 crash resulting in the testcase being unable to communicate with i3 via
\r
459 IPC anymore.</p></div>
\r
462 <div class="sect1">
\r
463 <h2 id="i3_sync">5. Appendix A: The i3 sync protocol</h2>
\r
464 <div class="sectionbody">
\r
465 <div class="paragraph"><p>Consider the following situation: You open two windows in your testcase, then
\r
466 you use <tt>focus left</tt> and want to verify that the X11 focus has been updated
\r
467 properly. Sounds simple, right? Let’s assume you use this straight-forward
\r
468 implementation:</p></div>
\r
469 <div class="listingblock">
\r
470 <div class="title">Racey focus testcase</div>
\r
471 <div class="content">
\r
472 <pre><tt>my $left = open_window($x);
\r
473 my $right = open_window($x);
\r
475 is($x->input_focus, $left->id, 'left window focused');</tt></pre>
\r
477 <div class="paragraph"><p>However, the test fails. Sometimes. Apparantly, there is a race condition in
\r
478 your test. If you think about it, this is because you are using two different
\r
479 pieces of software: You tell i3 to update focus, i3 confirms that, and then you
\r
480 ask X11 to give you the current focus. There is a certain time i3 needs to
\r
481 update the X11 state. If the testcase gets CPU time before X11 processed i3’s
\r
482 requests, the test will fail.</p></div>
\r
483 <div class="imageblock">
\r
484 <div class="content">
\r
485 <img src="i3-sync.png" alt="Diagram of the race condition" />
\r
487 <div class="title">Figure 1. Diagram of the race condition</div>
\r
489 <div class="paragraph"><p>One way to "solve" this would be to add <tt>sleep 0.5;</tt> after the <tt>cmd</tt> call.
\r
490 After 0.5 seconds it should be safe to assume that focus has been updated,
\r
492 <div class="paragraph"><p>In practice, this usually works. However, it has several problems:</p></div>
\r
493 <div class="olist arabic"><ol class="arabic">
\r
496 This is obviously not a clean solution, but a workaround. Ugly.
\r
501 On very slow machines, this might not work. Unlikely, but in different
\r
502 situations (a delay to wait for i3 to startup) the necessary time is much
\r
503 harder to guess, even for fast machines.
\r
508 This <strong>wastes a lot of time</strong>. Usually, your computer is much faster than 0.5s
\r
509 to update the status. However, sometimes, it might take 0.4s, so we can’t
\r
510 make it <tt>sleep 0.1</tt>.
\r
514 <div class="paragraph"><p>To illustrate how grave the problem with wasting time actually is: Before
\r
515 removing all sleeps from the testsuite, a typical run using 4 separate X
\r
516 servers took around 50 seconds on my machine. After removing all the sleeps,
\r
517 we achieved times of about 25 seconds. This is very significant and influences
\r
518 the way you think about tests — the faster they are, the more likely you are
\r
519 to check whether everything still works quite often (which you should).</p></div>
\r
520 <div class="paragraph"><p>What I am trying to say is: Delays adds up quickly and make the test suite
\r
521 less robust.</p></div>
\r
522 <div class="paragraph"><p>The real solution for this problem is a mechanism which I call "the i3 sync
\r
523 protocol". The idea is to send a request (which does not modify state) via X11
\r
524 to i3 which will then be answered. Due to the request’s position in the event
\r
525 queue (<strong>after</strong> all previous events), you can be sure that by the time you
\r
526 receive the reply, all other events have been dealt with by i3 (and, more
\r
527 importantly, X11).</p></div>
\r
528 <div class="imageblock">
\r
529 <div class="content">
\r
530 <img src="i3-sync-working.png" alt="Diagram of the i3 sync solution" />
\r
532 <div class="title">Figure 2. Diagram of the i3 sync solution</div>
\r
534 <div class="sect2">
\r
535 <h3 id="_implementation_details">5.1. Implementation details</h3>
\r
536 <div class="paragraph"><p>The client which wants to sync with i3 initiates the protocol by sending a
\r
537 ClientMessage to the X11 root window:</p></div>
\r
538 <div class="listingblock">
\r
539 <div class="title">Send ClientMessage</div>
\r
540 <div class="content">
\r
541 <pre><tt># Generate a ClientMessage, see xcb_client_message_t
\r
542 my $msg = pack "CCSLLLLLLL",
\r
543 CLIENT_MESSAGE, # response_type
\r
546 $root, # destination window
\r
547 $x->atom(name => 'I3_SYNC')->id,
\r
549 $_sync_window->id, # data[0]: our own window id
\r
550 $myrnd, # data[1]: a random value to identify the request
\r
555 # Send it to the root window -- since i3 uses the SubstructureRedirect
\r
556 # event mask, it will get the ClientMessage.
\r
557 $x->send_event(0, $root, EVENT_MASK_SUBSTRUCTURE_REDIRECT, $msg);</tt></pre>
\r
559 <div class="paragraph"><p>i3 will then reply with the same ClientMessage, sent to the window specified in
\r
560 <tt>data[0]</tt>. In the reply, <tt>data[0]</tt> and <tt>data[1]</tt> are exactly the same as in the
\r
561 request. You should use a random value in <tt>data[1]</tt> and check that you received
\r
562 the same one when getting the reply.</p></div>
\r
566 <div class="sect1">
\r
567 <h2 id="_appendix_b_socket_activation">6. Appendix B: Socket activation</h2>
\r
568 <div class="sectionbody">
\r
569 <div class="paragraph"><p>Socket activation is a mechanism which was made popular by systemd, an init
\r
570 replacement. It basically describes creating a listening socket before starting
\r
571 a program. systemd will invoke the program only when an actual connection to
\r
572 the socket is made, hence the term socket activation.</p></div>
\r
573 <div class="paragraph"><p>The interesting part of this (in the i3 context) is that you can very precisely
\r
574 detect when the program is ready (finished its initialization).</p></div>
\r
575 <div class="sect2">
\r
576 <h3 id="_preparing_the_listening_socket">6.1. Preparing the listening socket</h3>
\r
577 <div class="paragraph"><p><tt>complete-run.pl</tt> will create a listening UNIX socket which it will then pass
\r
578 to i3. This socket will be used by i3 as an additional IPC socket, just like
\r
579 the one it will create on its own. Passing the socket happens implicitly
\r
580 because children will inherit the parent’s sockets when fork()ing and sockets
\r
581 will continue to exist after an exec() call (unless CLOEXEC is set of course).</p></div>
\r
582 <div class="paragraph"><p>The only explicit things <tt>complete-run.pl</tt> has to do is setting the <tt>LISTEN_FDS</tt>
\r
583 environment variable to the number of sockets which exist (1 in our case) and
\r
584 setting the <tt>LISTEN_PID</tt> environment variable to the current process ID. Both
\r
585 variables are necessary so that the program (i3) knows how many sockets it
\r
586 should use and if the environment variable is actually intended for it. i3 will
\r
587 then start looking for sockets at file descriptor 3 (since 0, 1 and 2 are used
\r
588 for stdin, stdout and stderr, respectively).</p></div>
\r
589 <div class="paragraph"><p>The actual Perl code which sets up the socket, fork()s, makes sure the socket
\r
590 has file descriptor 3 and sets up the environment variables follows (shortened
\r
592 <div class="listingblock">
\r
593 <div class="title">Setup socket and environment</div>
\r
594 <div class="content">
\r
595 <pre><tt>my $socket = IO::Socket::UNIX->new(
\r
597 Local => $args{unix_socket_path},
\r
602 $ENV{LISTEN_PID} = $$;
\r
603 $ENV{LISTEN_FDS} = 1;
\r
605 # Only pass file descriptors 0 (stdin), 1 (stdout),
\r
606 # 2 (stderr) and 3 (socket) to the child.
\r
609 # If the socket does not use file descriptor 3 by chance
\r
610 # already, we close fd 3 and dup2() the socket to 3.
\r
611 if (fileno($socket) != 3) {
\r
613 POSIX::dup2(fileno($socket), 3);
\r
616 exec "/usr/bin/i3";
\r
620 <div class="sect2">
\r
621 <h3 id="_waiting_for_a_reply">6.2. Waiting for a reply</h3>
\r
622 <div class="paragraph"><p>In the parent process, we want to know when i3 is ready to answer our IPC
\r
623 requests and handle our windows. Therefore, after forking, we immediately close
\r
624 the listening socket (i3 will handle this side of the socket) and connect to it
\r
625 (remember, we are talking about a named UNIX socket) as a client. This connect
\r
626 call will immediately succeed because the kernel buffers it. Then, we send a
\r
627 request (of type GET_TREE, but that is not really relevant). Writing data to
\r
628 the socket will also succeed immediately because, again, the kernel buffers it
\r
629 (only up to a certain amount of data of course).</p></div>
\r
630 <div class="paragraph"><p>Afterwards, we just blockingly wait until we get an answer. In the child
\r
631 process, i3 will setup the listening socket in its event loop. Immediately
\r
632 after actually starting the event loop, it will notice a new client connecting
\r
633 (the parent process) and handle its request. Since all initialization has been
\r
634 completed successfully by the time the event loop is entered, we can now assume
\r
635 that i3 is ready.</p></div>
\r
637 <div class="sect2">
\r
638 <h3 id="_timing_and_conclusion">6.3. Timing and conclusion</h3>
\r
639 <div class="paragraph"><p>A beautiful feature of this mechanism is that it does not depend on timing. It
\r
640 does not matter when the child process gets CPU time or when the parent process
\r
641 gets CPU time. On heavily loaded machines (or machines with multiple CPUs,
\r
642 cores or unreliable schedulers), this makes waiting for i3 much more robust.</p></div>
\r
643 <div class="paragraph"><p>Before using socket activation, we typically used a <tt>sleep(1)</tt> and hoped that
\r
644 i3 was initialized by that time. Of course, this breaks on some (slow)
\r
645 computers and wastes a lot of time on faster computers. By using socket
\r
646 activation, we decreased the total amount of time necessary to run all tests
\r
647 (72 files at the time of writing) from > 100 seconds to 16 seconds. This makes
\r
648 it significantly more attractive to run the test suite more often (or at all)
\r
649 during development.</p></div>
\r
650 <div class="paragraph"><p>An alternative approach to using socket activation is polling for the existance
\r
651 of the IPC socket and connecting to it. While this might be slightly easier to
\r
652 implement, it wastes CPU time and is considerably uglier than this solution
\r
653 :). After all, <tt>lib/SocketActivation.pm</tt> contains only 54 SLOC.</p></div>
\r
658 <div id="footnotes"><hr /></div>
\r
659 <div id="footer" lang="de">
\r
660 © 2009-2011 Michael Stapelberg, <a href="/impress.html">Impressum</a>
\r
projects / i3 / i3.github.io / blob