]> git.sur5r.net Git - u-boot/commitdiff
ARM: sunxi: Remove left-over cd-inverted property from pcDuino3
authorTuomas Tynkkynen <tuomas@tuxera.com>
Fri, 22 Dec 2017 22:30:56 +0000 (00:30 +0200)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 10 Jan 2018 06:07:09 +0000 (11:37 +0530)
Commit 8620f384098b ("dm: sunxi: Linksprite_pcDuino3: Correct polarity
of MMC card detect") claims that the Pcduino3 device tree had an
incorrect polarity for the card detect pin and thus changed the polarity
flag of the cd-gpios from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.

Actually the DT was correct since according to the mmc binding, a
combination of GPIO_ACTIVE_HIGH + cd-inverted results in an active-low
polarity. But because the U-Boot driver lacks the code to look at the
cd-inverted property (unlike the Linux driver) it interpreted the
polarity of active-high. Thus, after that commit the DT is actually
wrong from the binding/Linux point of view.

To make both Linux and U-Boot interpret the DT in the same way, just
drop the left-over cd-inverted property. I've sent a Linux patch to
switch all sunxi DTs over to not using the cd-inverted property, so
eventually all sunxi boards in U-Boot will be consistent in not using
cd-inverted.

Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
arch/arm/dts/sun7i-a20-pcduino3.dts

index 37b1e0ee9bf688614317b1d3b422eea3c0165f51..7f449b6a283e3d2ea7fca4f626997ccd0903d17f 100644 (file)
        vmmc-supply = <&reg_vcc3v3>;
        bus-width = <4>;
        cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */
-       cd-inverted;
        status = "okay";
 };