Implement tab-completion in credit manager (#29)

[c128-kasse] / src / credit_manager.c

diff --git a/src/credit_manager.c b/src/credit_manager.c
index 6590f85542ef1ac5952db65c10f8d25fab51510f..91f6b3b187c2e7f362deaa0ff07dc552c68943b1 100644 (file)
--- a/src/credit_manager.c
+++ b/src/credit_manager.c
@@ -24,7 +24,7 @@ static BYTE current_credits_page = 0;
 
 static void credit_print_screen(void) {
   BYTE i, pages;
-  char buffer[10];
+  char buffer[EUR_FORMAT_MINLEN + 1];
 
   clrscr();
   cprintf("credit_manager (phil_fry, sECuRE, sur5r) v:" GV "\r\n\r\n");
@@ -54,17 +54,26 @@ static void credit_print_screen(void) {
           "z) Zur" uUML "ck\r\n");
 }
 
+static int8_t find_credit_idx(char *name) {
+  int8_t i;
+  for (i = 0; i < credits.num_items; ++i) {
+    if (strncmp(name, credits.credits[i].nickname, NICKNAME_MAX_LEN + 1) == 0) {
+      return i;
+    }
+  }
+  return -1;
+}
+
 struct credits_t *find_credit(char *name) {
   int i;
-  for (i = 0; i < credits.num_items; i++)
-    if (strncmp(name, credits.credits[i].nickname, NICKNAME_MAX_LEN + 1) == 0)
-      return &credits.credits[i];
+  if ((i = find_credit_idx(name)) >= 0) {
+    return &credits.credits[i];
+  }
   return NULL;
 }
 
 void deposit_credit(char *nickname) {
   char *time = get_time();
-  char *input;
   struct credits_t *credit;
   unsigned int deposit;
 
@@ -72,8 +81,7 @@ void deposit_credit(char *nickname) {
     return; // cannot find named credit
 
   cprintf("\r\nEinzahlung in Cent:\r\n");
-  if ((input = get_input()) == NULL || *input == '\0' ||
-      (deposit = atoi(input)) == 0)
+  if (cget_number(0) == 0)
     return;
 
   credit->credit += deposit;
@@ -84,7 +92,7 @@ void deposit_credit(char *nickname) {
 }
 
 static void new_credit(void) {
-  char *input, *name;
+  char name[NICKNAME_MAX_LEN + 1];
   char *time;
   int credit;
 
@@ -97,12 +105,17 @@ static void new_credit(void) {
 
   clrscr();
   cprintf("\rNickname (max. 10 Zeichen):\r\n");
-  if ((input = get_input()) == NULL || *input == '\0')
+  if (cgetn_input(name, sizeof(name)) == 0)
+    return;
+
+  if (find_credit_idx(name) >= 0) {
+    cprintf("\rNickname existiert bereits, dr" uUML "cke RETURN...\r\n");
+    cget_return();
     return;
-  name = strdup(input);
+  }
+
   cprintf("\r\nGuthaben in Cents:\r\n");
-  if ((input = get_input()) == NULL || *input == '\0' ||
-      (credit = atoi(input)) == 0)
+  if ((credit = cget_number(0)) == 0)
     return;
   strncpy(credits.credits[credits.num_items].nickname, name, NICKNAME_MAX_LEN);
   credits.credits[credits.num_items].credit = credit;
@@ -113,33 +126,23 @@ static void new_credit(void) {
   print_the_buffer();
 
   credits.num_items++;
-  free(name);
 }
 
-static void _delete_credit(BYTE num) {
-  memset(credits.credits[num].nickname, '\0', NICKNAME_MAX_LEN + 1);
-  credits.credits[num].credit = 0;
-}
-
-static void delete_credit(void) {
+static void delete_credit(char *nickname) {
   char *input;
-  BYTE num, last;
-
-  cprintf("\r Welcher Eintrag soll gel" oUML "scht werden?\r\n");
-  if ((input = get_input()) == NULL || *input == '\0')
+  int8_t i;
+  if ((i = find_credit_idx(nickname)) < 0) {
+    cprintf("\r Nick existiert nicht\r\n");
     return;
-  num = atoi(input);
-  if (credits.num_items > 1) {
-    /* Swap last item with this one and delete the last one to avoid holes */
-    last = (credits.num_items - 1);
-    strcpy(credits.credits[num].nickname, credits.credits[last].nickname);
-    credits.credits[num].credit = credits.credits[last].credit;
-    _delete_credit(last);
-  } else {
-    /* Just delete it */
-    _delete_credit(num);
   }
-  credits.num_items--;
+  --credits.num_items;
+  if (i != credits.num_items) {
+    credits.credits[i] = credits.credits[credits.num_items];
+  }
+  memset(credits.credits[credits.num_items].nickname, '\0',
+         NICKNAME_MAX_LEN + 1);
+  credits.credits[credits.num_items].credit = 0;
+  return;
 }
 
 void credit_manager() {
@@ -153,7 +156,10 @@ void credit_manager() {
       new_credit();
       break;
     case 'd':
-      delete_credit();
+      cputs("\rName?\r\n");
+      if (cget_nickname(nickname, sizeof(nickname))) {
+        delete_credit(nickname);
+      }
       break;
     case 's':
       save_credits();
@@ -168,8 +174,9 @@ void credit_manager() {
       break;
     case 'p':
       cputs("\rName?\r\n");
-      if (cgetn_input(nickname, sizeof(nickname)))
+      if (cget_nickname(nickname, sizeof(nickname))) {
         deposit_credit(nickname);
+      }
       break;
     case 'g':
       cprintf("Filter eingeben:\r\n");